webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 1491843004: [rtp_rtcp] RTT intermidiate calculation use ntp time instead of milliseconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 1491843004: [rtp_rtcp] RTT intermidiate calculation use ntp time instead of milliseconds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase & reduced RtpRtcpImplUnittest to more reasanable expectations Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtcp_sender_unittest.cc ('k') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index 09be51811f57123a4d3164c52468da856d77850b..90531c91a295a85528e9899a369ddb9c0de43808 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -901,16 +901,6 @@ int32_t ModuleRtpRtcpImpl::SendRTCPReferencePictureSelection(

GetFeedbackState(), kRtcpRpsi, 0, 0, false, picture_id);

}

-int64_t ModuleRtpRtcpImpl::SendTimeOfSendReport(

- const uint32_t send_report) {

- return rtcp_sender_.SendTimeOfSendReport(send_report);

-bool ModuleRtpRtcpImpl::SendTimeOfXrRrReport(

- uint32_t mid_ntp, int64_t* time_ms) const {

- return rtcp_sender_.SendTimeOfXrRrReport(mid_ntp, time_ms);

void ModuleRtpRtcpImpl::OnReceivedNACK(

const std::list<uint16_t>& nack_sequence_numbers) {

for (uint16_t nack_sequence_number : nack_sequence_numbers) {