webrtc/voice_engine/channel.cc - Issue 1491743004: Refactor WVoE DTMF handling #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/channel.cc

Issue 1491743004: Refactor WVoE DTMF handling #2 (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@wvoe_dtmf

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/voice_engine/channel.cc

diff --git a/webrtc/voice_engine/channel.cc b/webrtc/voice_engine/channel.cc

index 54aa802d73e4ccbca87d0f93cdeb73b536ad3329..fb9835664ac35dc2109ddc9e8bed651251f6ebac 100644

--- a/webrtc/voice_engine/channel.cc

+++ b/webrtc/voice_engine/channel.cc

@@ -2372,6 +2372,9 @@ int Channel::SendTelephoneEventOutband(unsigned char eventCode,

WEBRTC_TRACE(kTraceInfo, kTraceVoice, VoEId(_instanceId, _channelId),

"Channel::SendTelephoneEventOutband(..., playDtmfEvent=%d)",

playDtmfEvent);

+ if (!Sending()) {

+ return -1;

+ }

_playOutbandDtmfEvent = playDtmfEvent;

« no previous file with comments | « webrtc/test/mock_voe_channel_proxy.h ('k') | webrtc/voice_engine/channel_proxy.h » ('j') | no next file with comments »