Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1490703002: Revert of Add _decoder CHECK to VCMGenericDecoder constructor. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add _decoder CHECK to VCMGenericDecoder constructor. (patchset #2 id:20001 of https://codereview.webrtc.org/1485713002/ ) Reason for revert: Speculative revert since a downstream test started failing with this. Original issue's description: > Add _decoder CHECK to VCMGenericDecoder constructor. > > This should never be using a null decoder, but it looks like it's > crashing out in the field. Adding a CHECK to see if it catches any > interesting stack traces. > > Also making the _decoder pointer const to show that it should never be > changing. > > BUG=chromium:563299 > R=stefan@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/a443ec1a75d10be0f24fa0163f23e1555d4c53cf TBR=stefan@webrtc.org,pbos@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:563299 Committed: https://crrev.com/ec192bdb64d689415c34b74e10fc7859404abbf4 Cr-Commit-Position: refs/heads/master@{#10851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M webrtc/modules/video_coding/codec_database.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 5 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
Created Revert of Add _decoder CHECK to VCMGenericDecoder constructor.
5 years ago (2015-12-01 07:14:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490703002/1
5 years ago (2015-12-01 07:14:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 07:14:35 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec192bdb64d689415c34b74e10fc7859404abbf4 Cr-Commit-Position: refs/heads/master@{#10851}
5 years ago (2015-12-01 07:14:45 UTC) #5
kjellander_webrtc
5 years ago (2015-12-01 07:53:23 UTC) #6
Message was sent while issue was closed.
On 2015/12/01 07:14:45, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ec192bdb64d689415c34b74e10fc7859404abbf4
> Cr-Commit-Position: refs/heads/master@{#10851}

This revert helped, and all those tests are green again.

Powered by Google App Engine
This is Rietveld 408576698