Chromium Code Reviews

Issue 1490403002: In some rare Android systems ConnectivityManager may be null. (Closed)

Created:
5 years ago by honghaiz3
Modified:
5 years ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In some rare Android systems ConnectivityManager may be null. Handle this case more gracefully. BUG= Committed: https://crrev.com/9462052f32fd777f5437c1e0803246cf6aaa5cdf Cr-Commit-Position: refs/heads/master@{#10875}

Patch Set 1 : #

Unified diffs Side-by-side diffs Stats (+19 lines, -0 lines)
M talk/app/webrtc/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 6 chunks +19 lines, -0 lines 0 comments

Messages

Total messages: 11 (6 generated)
honghaiz3
5 years ago (2015-12-02 19:20:29 UTC) #3
AlexG
lgtm
5 years ago (2015-12-02 21:21:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490403002/20001
5 years ago (2015-12-02 21:30:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-12-02 22:29:08 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-02 22:33:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9462052f32fd777f5437c1e0803246cf6aaa5cdf
Cr-Commit-Position: refs/heads/master@{#10875}

Powered by Google App Engine