Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1490333004: HighPassFilter not a ProcessingComponent anymore (bit exact). (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make HighPassFilter not a ProcessingComponent anymore (bit exact). BUG=webrtc:5298 Committed: https://crrev.com/70f9903e570931831a027ba6f91c164efc604a85 Cr-Commit-Position: refs/heads/master@{#10939}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : now even compiles #

Patch Set 4 : bah, win compile error #

Patch Set 5 : win compile again #

Patch Set 6 : rebase #

Total comments: 17

Patch Set 7 : comments by hlundin #

Patch Set 8 : now bitexact #

Patch Set 9 : rebase #

Patch Set 10 : Less pessimistic locking #

Total comments: 2

Patch Set 11 : comments+rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -159 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 3 4 5 6 7 9 chunks +15 lines, -8 lines 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +12 lines, -20 lines 0 comments Download
M webrtc/modules/audio_processing/high_pass_filter_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +81 lines, -131 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (12 generated)
the sun
5 years ago (2015-12-02 23:27:21 UTC) #2
the sun
On 2015/12/02 23:27:21, the sun wrote: Compilers seem to have bought it now. PTAL.
5 years ago (2015-12-03 10:40:39 UTC) #4
hlundin-webrtc
https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc File webrtc/modules/audio_processing/high_pass_filter_impl.cc (right): https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc#newcode25 webrtc/modules/audio_processing/high_pass_filter_impl.cc:25: explicit MonoFilter(int sample_rate_hz) { If you initialize ba_ as ...
5 years ago (2015-12-04 12:30:09 UTC) #8
the sun
https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc File webrtc/modules/audio_processing/high_pass_filter_impl.cc (right): https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc#newcode25 webrtc/modules/audio_processing/high_pass_filter_impl.cc:25: explicit MonoFilter(int sample_rate_hz) { On 2015/12/04 12:30:09, hlundin-webrtc wrote: ...
5 years ago (2015-12-04 14:53:31 UTC) #9
hlundin-webrtc
lgtm, for what it's worth... https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc File webrtc/modules/audio_processing/high_pass_filter_impl.cc (right): https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/high_pass_filter_impl.cc#newcode36 webrtc/modules/audio_processing/high_pass_filter_impl.cc:36: const int16_t* ba = ...
5 years ago (2015-12-04 15:11:09 UTC) #10
peah-webrtc
https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (right): https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode1297 webrtc/modules/audio_processing/audio_processing_impl.cc:1297: int channels = num_output_channels(); Why are the number of ...
5 years ago (2015-12-08 14:52:27 UTC) #12
the sun
https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc File webrtc/modules/audio_processing/audio_processing_impl.cc (right): https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode1297 webrtc/modules/audio_processing/audio_processing_impl.cc:1297: int channels = num_output_channels(); On 2015/12/08 14:52:27, peah-webrtc wrote: ...
5 years ago (2015-12-08 15:08:06 UTC) #13
peah-webrtc
On 2015/12/08 15:08:06, the sun wrote: > https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc > File webrtc/modules/audio_processing/audio_processing_impl.cc (right): > > https://codereview.webrtc.org/1490333004/diff/100001/webrtc/modules/audio_processing/audio_processing_impl.cc#newcode1297 ...
5 years ago (2015-12-08 15:09:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490333004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490333004/200001
5 years ago (2015-12-08 15:11:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/363)
5 years ago (2015-12-08 16:11:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490333004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490333004/200001
5 years ago (2015-12-08 17:47:44 UTC) #21
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years ago (2015-12-08 19:07:35 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-08 19:07:45 UTC) #25
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/70f9903e570931831a027ba6f91c164efc604a85
Cr-Commit-Position: refs/heads/master@{#10939}

Powered by Google App Engine
This is Rietveld 408576698