Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1490233010: Clear old decoders after recreating the receiver. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clear old decoders after recreating the receiver. Prevents UAF when switching decoder capabilities and the previously-supported decoder is currently being received on. BUG=chromium:565967 R=stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9e1b992f74470aecfeb216e26b455982ddc4a6d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/media/webrtc/webrtcvideoengine2.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pbos-webrtc
PTAL
5 years ago (2015-12-04 15:27:21 UTC) #1
stefan-webrtc
Please add a test.
5 years ago (2015-12-04 15:31:33 UTC) #2
stefan-webrtc
lgtm
5 years ago (2015-12-04 15:33:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e1b992f74470aecfeb216e26b455982ddc4a6d5 Cr-Commit-Position: refs/heads/master@{#10898}
5 years ago (2015-12-04 15:34:20 UTC) #5
pbos-webrtc
5 years ago (2015-12-04 15:34:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e1b992f74470aecfeb216e26b455982ddc4a6d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698