Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1489363002: Fix VideoCaptureAndroid, drop frame when switching camera using textures. (Closed)

Created:
5 years ago by perkj_webrtc
Modified:
5 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix VideoCaptureAndroid, drop frame when switching camera using textures. Dropping the first frame intended to fix a problem when switching cameras on N6 when we are capturing to textures but due to a silly bug fixed in this cl the frame was not dropped... BUG=webrtc:4993 TBR=magjed@webrtc.org Committed: https://crrev.com/d20d24716697f9ecdee02c279a51018ee95baab2 Cr-Commit-Position: refs/heads/master@{#10867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_webrtc
please
5 years ago (2015-12-02 09:58:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489363002/1
5 years ago (2015-12-02 09:59:08 UTC) #3
magjed_webrtc
lgtm o_O
5 years ago (2015-12-02 09:59:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 12:25:32 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-02 12:25:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20d24716697f9ecdee02c279a51018ee95baab2
Cr-Commit-Position: refs/heads/master@{#10867}

Powered by Google App Engine
This is Rietveld 408576698