Added two more debug macros for logging scalar values to file.

webrtc/modules/audio_processing/logging/aec_logging.h

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 25 matching lines @@
   do {                                    \
     rtc_WavClose(wav_file);               \
   } while (0)
 
 // Dumps a raw data to file.
 #define RTC_AEC_DEBUG_RAW_WRITE(file, data, data_size) \
   do {                                                 \
     (void) fwrite(data, data_size, 1, file);           \
   } while (0)
 
+// Dumps a raw scalar int32 to file.
+#define RTC_AEC_DEBUG_RAW_WRITE_SCALAR_INT32(file, data)             \
+  do {                                                               \
+    int32_t value_to_store = data;                                   \

[ivoc, 2015/12/01 09:47:52]

Would it be possible/desirable to merge this with the macro below by changing
int32_t to auto?

[peah-webrtc, 2015/12/01 12:21:43]

I think you are right in that it could. My only concern is that we miss the
typecheck if the writing to a certain file happens in several places and may
therefore write it in different formats in different places.

Also, afaics the auto makes it up to the compiler to choose the format, right,
and I guess that it would adapt it to the type of value being written.
For instance in:
int16_t luke=32768;
int16_t skywalker=32768;
RTC_AEC_DEBUG_RAW_WRITE_SCALAR_AUTO(luke*skywalker);
I guess that that would store the value in int32, but it is less straightforward
to see that.

My intended use of this is to read the values into matlab using fread, and then
I need to know the value type, and for me it would be easier to read the logs if
I know whether it either an int32_t or a double.

What do you think? Maybe the auto-scheme could be adapted to allow a simple read
functionality when retrieving the stored data?

+    (void) fwrite(&value_to_store, sizeof(value_to_store), 1, file); \
+  } while (0)
+
+// Dumps a raw scalar double to file.
+#define RTC_AEC_DEBUG_RAW_WRITE_SCALAR_DOUBLE(file, data)            \
+  do {                                                               \
+    double value_to_store = data;                                    \
+    (void) fwrite(&value_to_store, sizeof(value_to_store), 1, file); \
+  } while (0)
+

[kwiberg-webrtc, 2015/11/30 14:55:43]

Drive-by: Please consider using inline functions instead of introducing even
more macros. Something like

static inline void blupp(FILE* file, double data) {
#ifdef BLIPP
  (void) fwrite(&data, sizeof(data), 1, file);
#endif
}

ought to work fine.

 // Opens a raw data file for writing using the specified sample rate.
 #define RTC_AEC_DEBUG_RAW_OPEN(name, instance_counter, file) \
   do {                                                       \
     WebRtcAec_RawFileOpen(name, instance_counter, file);     \
   } while (0)
 
 // Closes a raw data file.
 #define RTC_AEC_DEBUG_RAW_CLOSE(file) \
   do {                                \
     fclose(file);                     \
@@ skipping 10 matching lines @@
   } while (0)
 
 #define RTC_AEC_DEBUG_WAV_CLOSE(wav_file) \
   do {                                    \
   } while (0)
 
 #define RTC_AEC_DEBUG_RAW_WRITE(file, data, data_size) \
   do {                                                 \
   } while (0)
 
+#define RTC_AEC_DEBUG_RAW_WRITE_SCALAR_INT32(file, data) \
+  do {                                                   \
+  } while (0)
+
+#define RTC_AEC_DEBUG_RAW_WRITE_SCALAR_DOUBLE(file, data) \
+  do {                                                    \
+  } while (0)
+
 #define RTC_AEC_DEBUG_RAW_OPEN(file, name, instance_counter) \
   do {                                                       \
   } while (0)
 
 #define RTC_AEC_DEBUG_RAW_CLOSE(file) \
   do {                                \
   } while (0)
 
 #endif  // WEBRTC_AEC_DEBUG_DUMP
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_AEC_AEC_LOGGING_