Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1487393002: Refactor WVoE DTMF handling #1 (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

- Remove cricket::VoiceChannel::PressDtmf(); AFAICT unused. - Remove the DF_PLAY/DF_SEND flags, only allow sending. BUG=webrtc:4690 Committed: https://crrev.com/1d63dd0eaa44d13c5ae083200937b18bce2132ae Cr-Commit-Position: refs/heads/master@{#10872}

Patch Set 1 #

Patch Set 2 : -TODOs #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -133 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 1 chunk +1 line, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 3 chunks +6 lines, -10 lines 0 comments Download
M talk/media/base/mediachannel.h View 2 chunks +3 lines, -13 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 2 chunks +2 lines, -9 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 1 chunk +18 lines, -31 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 1 chunk +4 lines, -17 lines 0 comments Download
M talk/session/media/channel.h View 3 chunks +2 lines, -4 lines 0 comments Download
M talk/session/media/channel.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 2 chunks +6 lines, -24 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (15 generated)
the sun
5 years ago (2015-12-02 13:45:12 UTC) #3
pthatcher1
lgtm
5 years ago (2015-12-02 18:48:10 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487393002/40001
5 years ago (2015-12-02 18:52:57 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 19:52:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487393002/40001
5 years ago (2015-12-02 20:02:58 UTC) #11
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years ago (2015-12-02 20:17:29 UTC) #12
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
5 years ago (2015-12-02 20:19:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1487393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1487393002/40001
5 years ago (2015-12-02 20:22:54 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 20:35:12 UTC) #23
commit-bot: I haz the power
5 years ago (2015-12-02 20:35:23 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d63dd0eaa44d13c5ae083200937b18bce2132ae
Cr-Commit-Position: refs/heads/master@{#10872}

Powered by Google App Engine
This is Rietveld 408576698