Adding Java binding for CreateSender.

Adding Java binding for CreateSender.

Committed: https://crrev.com/ee524f7c02cad35b453d5832ef14640603256e39
Cr-Commit-Position: refs/heads/master@{#10871}

[Taylor Brandstetter, 2015-12-01 22:53:51]

deadbeef@webrtc.org changed reviewers:
+ glaznev@webrtc.org, pthatcher@webrtc.org

[Taylor Brandstetter, 2015-12-01 22:53:52]

PTAL Alex.

[AlexG, 2015-12-02 00:50:16]

lgtm

https://codereview.webrtc.org/1486243002/diff/1/talk/app/webrtc/java/jni/peer...
File talk/app/webrtc/java/jni/peerconnection_jni.cc (right):

https://codereview.webrtc.org/1486243002/diff/1/talk/app/webrtc/java/jni/peer...
talk/app/webrtc/java/jni/peerconnection_jni.cc:1772: // Sender is now owned by
Java object, and will be freed from there.
nit: extend comment to list what method will free senders - I guess
peerconnection.dispose() and getSenders() ?

https://codereview.webrtc.org/1486243002/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/PeerConnection.java (left):

https://codereview.webrtc.org/1486243002/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/PeerConnection.java:31: import
java.util.ArrayList;
nit: remove this import - it is not used

[pthatcher1, 2015-12-02 19:17:06]

lgtm, with nits

https://codereview.webrtc.org/1486243002/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/PeerConnection.java (right):

https://codereview.webrtc.org/1486243002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/PeerConnection.java:225: public RtpSender
createSender(String kind) {
Should we put a comment saying that it can return null, and what that means?

https://codereview.webrtc.org/1486243002/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/PeerConnection.java:226: RtpSender
new_sender = nativeCreateSender(kind);
Why not just "sender"?

[Taylor Brandstetter, 2015-12-02 19:22:18]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2015-12-02 19:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1486243002/#ps20001 (title:
"Addressing nits.")

[commit-bot: I haz the power, 2015-12-02 19:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1486243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1486243002/20001

[commit-bot: I haz the power, 2015-12-02 19:27:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-02 19:27:52]

Description was changed from

==========
Adding Java binding for CreateSender.
==========

to

==========
Adding Java binding for CreateSender.

Committed: https://crrev.com/ee524f7c02cad35b453d5832ef14640603256e39
Cr-Commit-Position: refs/heads/master@{#10871}
==========

[commit-bot: I haz the power, 2015-12-02 19:27:54]

Patchset 2 (id:??) landed as
https://crrev.com/ee524f7c02cad35b453d5832ef14640603256e39
Cr-Commit-Position: refs/heads/master@{#10871}