Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1486143002: Only pass android_toolchain in android builds. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax.git@master
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only pass android_toolchain in android builds. Unbreaks non-android arm builds of openmax. BUG=563844 R=rtoy@google.com Committed: https://chromium.googlesource.com/external/webrtc/deps/third_party/openmax/+/7a179b97899cf33d4a12c7ef590176c519016f4d

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M dl/BUILD.gn View 1 1 chunk +7 lines, -6 lines 0 comments Download
M dl/dl.gyp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Nico
Sorry, looks like I missed a configuration :-( I tested arm/android and arm/linux this time.
5 years ago (2015-12-01 15:49:45 UTC) #2
Raymond Toy (Google)
lgtm
5 years ago (2015-12-01 16:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486143002/20001
5 years ago (2015-12-01 16:52:20 UTC) #6
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years ago (2015-12-01 16:52:21 UTC) #8
Raymond Toy (Google)
5 years ago (2015-12-01 16:53:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7a179b97899cf33d4a12c7ef590176c519016f4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698