Add _decoder CHECK to VCMGenericDecoder constructor.

Add _decoder CHECK to VCMGenericDecoder constructor.

This should never be using a null decoder, but it looks like it's
crashing out in the field. Adding a CHECK to see if it catches any
interesting stack traces.

Also making the _decoder pointer const to show that it should never be
changing.

BUG=chromium:563299
R=stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/a443ec1a75d10be0f24fa0163f23e1555d4c53cf

[pbos-webrtc, 2015-11-30 16:16:58]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-11-30 16:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485713002/1

[commit-bot: I haz the power, 2015-11-30 16:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 16:17:03]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pbos-webrtc, 2015-11-30 16:17:06]

PTAL

[pbos-webrtc, 2015-11-30 16:17:58]

include header

[pbos-webrtc, 2015-11-30 16:18:09]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-30 16:18:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485713002/20001

[stefan-webrtc, 2015-11-30 16:22:20]

lgtm

[pbos-webrtc, 2015-11-30 16:22:56]

The CQ bit was unchecked by pbos@webrtc.org

[pbos-webrtc, 2015-11-30 16:23:02]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-11-30 16:23:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485713002/20001

[commit-bot: I haz the power, 2015-11-30 16:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-30 16:43:37]

Try jobs failed on following builders:
  linux_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/10962)

[pbos-webrtc, 2015-11-30 18:10:04]

The CQ bit was checked by pbos@webrtc.org

[commit-bot: I haz the power, 2015-11-30 18:10:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485713002/20001

[commit-bot: I haz the power, 2015-11-30 18:15:05]

Description was changed from

==========
Add _decoder CHECK to VCMGenericDecoder constructor.

This should never be using a null decoder, but it looks like it's
crashing out in the field. Adding a CHECK to see if it catches any
interesting stack traces.

Also making the _decoder pointer const to show that it should never be
changing.

BUG=chromium:563299
R=stefan@webrtc.org
==========

to

==========
Add _decoder CHECK to VCMGenericDecoder constructor.

This should never be using a null decoder, but it looks like it's
crashing out in the field. Adding a CHECK to see if it catches any
interesting stack traces.

Also making the _decoder pointer const to show that it should never be
changing.

BUG=chromium:563299
R=stefan@webrtc.org

Committed: https://crrev.com/a443ec1a75d10be0f24fa0163f23e1555d4c53cf
Cr-Commit-Position: refs/heads/master@{#10843}
==========

[commit-bot: I haz the power, 2015-11-30 18:15:06]

Patchset 2 (id:??) landed as
https://crrev.com/a443ec1a75d10be0f24fa0163f23e1555d4c53cf
Cr-Commit-Position: refs/heads/master@{#10843}

[pbos-webrtc, 2015-11-30 18:15:11]

Description was changed from

==========
Add _decoder CHECK to VCMGenericDecoder constructor.

This should never be using a null decoder, but it looks like it's
crashing out in the field. Adding a CHECK to see if it catches any
interesting stack traces.

Also making the _decoder pointer const to show that it should never be
changing.

BUG=chromium:563299
R=stefan@webrtc.org

Committed: https://crrev.com/a443ec1a75d10be0f24fa0163f23e1555d4c53cf
Cr-Commit-Position: refs/heads/master@{#10843}
==========

to

==========
Add _decoder CHECK to VCMGenericDecoder constructor.

This should never be using a null decoder, but it looks like it's
crashing out in the field. Adding a CHECK to see if it catches any
interesting stack traces.

Also making the _decoder pointer const to show that it should never be
changing.

BUG=chromium:563299
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/a443ec1a75d10be0f24fa0163...
==========

[pbos-webrtc, 2015-11-30 18:15:12]

Committed patchset #2 (id:20001) manually as
a443ec1a75d10be0f24fa0163f23e1555d4c53cf (presubmit successful).

[kjellander_webrtc, 2015-12-01 07:14:23]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1490703002/ by kjellander@webrtc.org.

The reason for reverting is: Speculative revert since a downstream test started
failing with this..