Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1485673003: WebRtcVideoCapturer: SetCaptureState(CS_STOPPED) on Stop and ensure state changes in unittest (Closed)

Created:
5 years ago by hbos
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVideoCapturer: SetCaptureState(CS_STOPPED) on Stop and ensure state changes in unittest. Related to issues discussed in the referenced bug but does not solve that bug's main problem. BUG=webrtc:4776 Committed: https://crrev.com/0de97f1b748d8238fe3a7ad8d7afb2b6cb456a3e Cr-Commit-Position: refs/heads/master@{#10852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M talk/media/webrtc/webrtcvideocapturer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideocapturer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
hbos
Please take a look perkj, pthatcher.
5 years ago (2015-11-30 15:58:14 UTC) #4
pthatcher
lgtm
5 years ago (2015-11-30 18:14:45 UTC) #6
perkj_webrtc
lgtm
5 years ago (2015-12-01 06:43:03 UTC) #7
perkj_webrtc
lgtm
5 years ago (2015-12-01 06:43:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1485673003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1485673003/1
5 years ago (2015-12-01 10:00:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 10:13:38 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-01 10:13:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0de97f1b748d8238fe3a7ad8d7afb2b6cb456a3e
Cr-Commit-Position: refs/heads/master@{#10852}

Powered by Google App Engine
This is Rietveld 408576698