webrtc/modules/audio_coding/neteq/include/neteq.h - Issue 1484343003: NetEq: Add codec name and RTP timestamp rate to DecoderInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/include/neteq.h

Issue 1484343003: NetEq: Add codec name and RTP timestamp rate to DecoderInfo (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/neteq/decoder_database_unittest.cc ('K') | « webrtc/modules/audio_coding/neteq/decoder_database_unittest.cc ('k') | webrtc/modules/audio_coding/neteq/mock/mock_decoder_database.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/include/neteq.h

diff --git a/webrtc/modules/audio_coding/neteq/include/neteq.h b/webrtc/modules/audio_coding/neteq/include/neteq.h

index 88677d83558735a7643e57f89d9971ec16537b9b..0856f8f802b82a08bd4edb04ebcbc2cb846e0ff6 100644

--- a/webrtc/modules/audio_coding/neteq/include/neteq.h

+++ b/webrtc/modules/audio_coding/neteq/include/neteq.h

@@ -181,10 +181,12 @@ class NetEq {

// Provides an externally created decoder object |decoder| to insert in the

// decoder database. The decoder implements a decoder of type |codec| and

- // associates it with |rtp_payload_type|. The decoder will produce samples

- // at the rate |sample_rate_hz|. Returns kOK on success, kFail on failure.

+ // associates it with |rtp_payload_type| and |codec_name|. The decoder will

+ // produce samples at the rate |sample_rate_hz|. Returns kOK on success, kFail

+ // on failure.

kwiberg-webrtc 2015/12/02 09:50:42 You don't explain what the name is used for. Will

hlundin-webrtc 2015/12/02 16:19:24 Done.

virtual int RegisterExternalDecoder(AudioDecoder* decoder,

NetEqDecoder codec,

+ const std::string& codec_name,

uint8_t rtp_payload_type,

int sample_rate_hz) = 0;