webrtc/modules/audio_coding/include/audio_coding_module.h - Issue 1484343003: NetEq: Add codec name and RTP timestamp rate to DecoderInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/include/audio_coding_module.h

Issue 1484343003: NetEq: Add codec name and RTP timestamp rate to DecoderInfo (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc ('K') | « webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc ('k') | webrtc/modules/audio_coding/neteq/decoder_database.h » ('j') | webrtc/modules/audio_coding/neteq/decoder_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/include/audio_coding_module.h

diff --git a/webrtc/modules/audio_coding/include/audio_coding_module.h b/webrtc/modules/audio_coding/include/audio_coding_module.h

index 844bd57cd19a81d8f516cc361e519f26adf6531b..f36732f8a2191a526c1dd6efeb8892a1ee0a9372 100644

--- a/webrtc/modules/audio_coding/include/audio_coding_module.h

+++ b/webrtc/modules/audio_coding/include/audio_coding_module.h

@@ -11,6 +11,7 @@

#ifndef WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_

#define WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_

+#include <string>

#include <vector>

#include "webrtc/base/optional.h"

@@ -474,7 +475,8 @@ class AudioCodingModule {

virtual int RegisterExternalReceiveCodec(int rtp_payload_type,

AudioDecoder* external_decoder,

int sample_rate_hz,

- int num_channels) = 0;

+ int num_channels,

+ const std::string& name) = 0;

kwiberg-webrtc 2015/12/02 09:50:42 You don't explain what the name is used for. (This

hlundin-webrtc 2015/12/02 16:19:24 Done.

///////////////////////////////////////////////////////////////////////////

// int32_t UnregisterReceiveCodec()