Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1483613002: Fix standalone denoiser Android GN compile failure (Closed)

Created:
5 years ago by magjed_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix standalone denoiser Android GN compile failure BUG=webrtc:5255 R=pbos@webrtc.org TBR=kjellander Committed: https://chromium.googlesource.com/external/webrtc/+/8779a777f848e6651f80eb343e02d938bff5387a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/modules/video_processing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Please take a look.
5 years ago (2015-11-27 10:38:19 UTC) #3
pbos-webrtc
lgtm
5 years ago (2015-11-27 10:43:41 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8779a777f848e6651f80eb343e02d938bff5387a Cr-Commit-Position: refs/heads/master@{#10818}
5 years ago (2015-11-27 11:03:09 UTC) #8
magjed_webrtc
Committed patchset #1 (id:1) manually as 8779a777f848e6651f80eb343e02d938bff5387a (presubmit successful).
5 years ago (2015-11-27 11:03:12 UTC) #9
kjellander_webrtc
5 years ago (2015-11-27 11:42:08 UTC) #10
Message was sent while issue was closed. 
lgtm, thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698