Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1483423002: Remove VideoReceiveStream deregister of decoders. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, andresp, the sun, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoReceiveStream deregister of decoders. Also doing some simplifications inside video_coding. No CHECKs added, since they appear to have introduced breakages in downstream tests. Overall reducing the number of potential ways a decoder could possibly be set null. Removing deregistration of external decoders should also give a quicker shutdown time since that may attempt to register internal decoders. BUG=chromium:563299 TBR=stefan@webrtc.org Committed: https://crrev.com/187db63fdfbfb462a722b685e4a1faf40632d257 Cr-Commit-Position: refs/heads/master@{#10858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -94 lines) Patch
M webrtc/modules/video_coding/codec_database.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 8 chunks +16 lines, -34 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 4 chunks +23 lines, -34 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.cc View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pbos-webrtc
PTAL, if I'm suuuper lucky the null decoder comes from DeRegisterExternalDecoders, but I don't see ...
5 years ago (2015-12-01 15:04:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1483423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1483423002/1
5 years ago (2015-12-01 15:04:41 UTC) #3
pbos-webrtc
TBR= to get this in the next roll
5 years ago (2015-12-01 16:17:20 UTC) #5
pbos-webrtc
Committed patchset #1 (id:1) manually as 187db63fdfbfb462a722b685e4a1faf40632d257 (presubmit successful).
5 years ago (2015-12-01 16:20:14 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 16:20:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/187db63fdfbfb462a722b685e4a1faf40632d257
Cr-Commit-Position: refs/heads/master@{#10858}

Powered by Google App Engine
This is Rietveld 408576698