Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1482703002: Use ChannelProxy for most calls on voe::Channel in Audio[Receive|Send]Stream. (Closed)

Created:
5 years ago by the sun
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, Stefan
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use ChannelProxy for most calls on voe::Channel in Audio[Receive|Send]Stream. BUG=webrtc:4690 Committed: https://crrev.com/358057b945725390bcecc330513160aa823f651e Cr-Commit-Position: refs/heads/master@{#10828}

Patch Set 1 #

Patch Set 2 : Added ThreadChecker to ChannelProxy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -98 lines) Patch
M webrtc/audio/audio_receive_stream.cc View 4 chunks +8 lines, -40 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 2 chunks +18 lines, -19 lines 0 comments Download
M webrtc/audio/audio_send_stream.cc View 4 chunks +6 lines, -22 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 1 chunk +78 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
the sun
pbos@ for webrtc/test/
5 years ago (2015-11-27 10:27:19 UTC) #2
the sun
On 2015/11/27 10:27:19, the sun wrote: > pbos@ for webrtc/test/ Ignore that.
5 years ago (2015-11-27 10:27:59 UTC) #3
tommi
lgtm
5 years ago (2015-11-27 17:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482703002/20001
5 years ago (2015-11-27 17:20:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 18:46:47 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-27 18:46:56 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/358057b945725390bcecc330513160aa823f651e
Cr-Commit-Position: refs/heads/master@{#10828}

Powered by Google App Engine
This is Rietveld 408576698