Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1482593002: Introduce helper class NtpTime (Closed)

Created:
5 years ago by danilchap
Modified:
5 years ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, Andrew MacDonald, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Introduce helper class NtpTime Seconds and fractions parts of the ntp time presented with two values, but used as one. This helper structure can make that use more clear. (initially introduced into rtp_rtcp as https://codereview.webrtc.org/1435833003) BUG=webrtc:5260 Committed: https://crrev.com/b1ac20348046d9de0778f937dc1d9d2bcdbd1a79 Cr-Commit-Position: refs/heads/master@{#10814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
A webrtc/system_wrappers/include/ntp_time.h View 1 chunk +63 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/source/ntp_time_unittest.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
danilchap
5 years ago (2015-11-26 09:46:08 UTC) #4
mflodman
LGTM
5 years ago (2015-11-26 12:32:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482593002/1
5 years ago (2015-11-26 12:33:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-26 14:33:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482593002/1
5 years ago (2015-11-26 16:03:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 17:01:14 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-26 17:01:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1ac20348046d9de0778f937dc1d9d2bcdbd1a79
Cr-Commit-Position: refs/heads/master@{#10814}

Powered by Google App Engine
This is Rietveld 408576698