Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1482443003:
Roll chromium_revision aa8e58a..664fe1e (361601:361806) (Closed)
|
Created:
5 years ago by kjellander_webrtc Modified:
5 years ago Reviewers:
henrika_webrtc CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision aa8e58a..664fe1e (361601:361806)
webrtc/modules/audio_device/android/ensure_initialized.cc needed to
be updated due to https://codereview.chromium.org/1407233017
Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e
Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e
No dependencies changed.
No update to Clang.
NOTRY=True
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
R=henrika@webrtc.org
Committed: https://crrev.com/c03bdf9ae96ce12aedd0fee021782344a757fa68
Cr-Commit-Position: refs/heads/master@{#10798}
Patch Set 1 #Patch Set 2 : Fixing webrtc/modules/audio_device/android/ensure_initialized.cc #Messages
Total messages: 18 (10 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482443003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...) android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/9362)
Description was changed from ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
kjellander@webrtc.org changed reviewers: + henrika@webrtc.org
Description was changed from ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
henrika: please take a look at webrtc/modules/audio_device/android/ensure_initialized.cc
LGTM. Thanks for fixing.
Description was changed from ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. TBR= CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. NOTRY=True CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1482443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1482443003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1997)
Description was changed from ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. NOTRY=True CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal ========== to ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. NOTRY=True CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal R=henrika@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c03bdf9ae96ce12aedd0fee02... ==========
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. NOTRY=True CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal R=henrika@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/c03bdf9ae96ce12aedd0fee02... ========== to ========== Roll chromium_revision aa8e58a..664fe1e (361601:361806) webrtc/modules/audio_device/android/ensure_initialized.cc needed to be updated due to https://codereview.chromium.org/1407233017 Change log: https://chromium.googlesource.com/chromium/src/+log/aa8e58a..664fe1e Full diff: https://chromium.googlesource.com/chromium/src/+/aa8e58a..664fe1e No dependencies changed. No update to Clang. NOTRY=True CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal R=henrika@webrtc.org Committed: https://crrev.com/c03bdf9ae96ce12aedd0fee021782344a757fa68 Cr-Commit-Position: refs/heads/master@{#10798} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as c03bdf9ae96ce12aedd0fee021782344a757fa68.
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c03bdf9ae96ce12aedd0fee021782344a757fa68 Cr-Commit-Position: refs/heads/master@{#10798} |
