Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1481723003: Enable cpplint for webrtc/video_engine (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), Andrew MacDonald, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, peah-webrtc, the sun, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable cpplint for webrtc/video_engine Enable cpplint and have it use a whitelist that also checks in subdirectories. Move the cpplint check so it runs before the pylint check since that one always run and increases the time to errors for cpplint. Fix all cpplint errors in webrtc/video_engine. BUG=webrtc:5149 TESTED=Fixed issues reported by: find webrtc/video_engine -type f -name *.cc -o -name *.h | xargs cpplint.py followed by 'git cl presubmit'. R=pbos@chromium.org, phoglund@chromium.org TBR=pbos@webrtc.org, phoglund@webrtc.org Committed: https://crrev.com/0fcaf99b716c71e721db25f37f62dabf5dcbe69a Cr-Commit-Position: refs/heads/master@{#10808}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -17 lines) Patch
M PRESUBMIT.py View 6 chunks +20 lines, -2 lines 0 comments Download
M webrtc/video_engine/overuse_frame_detector.h View 3 chunks +7 lines, -7 lines 2 comments Download
M webrtc/video_engine/overuse_frame_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/payload_router_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/stream_synchronization_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_receiver.h View 3 chunks +3 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_remb_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
kjellander_webrtc
phoglund: PRESUBMIT.py pbos: webrtc/video_engine
5 years ago (2015-11-26 13:50:11 UTC) #2
pbos
https://codereview.chromium.org/1481723003/diff/1/webrtc/video_engine/overuse_frame_detector.h File webrtc/video_engine/overuse_frame_detector.h (right): https://codereview.chromium.org/1481723003/diff/1/webrtc/video_engine/overuse_frame_detector.h#newcode53 webrtc/video_engine/overuse_frame_detector.h:53: int high_encode_usage_threshold_percent; // Threshold for triggering overuse. run git ...
5 years ago (2015-11-26 13:51:58 UTC) #4
kjellander_webrtc
https://codereview.chromium.org/1481723003/diff/1/webrtc/video_engine/overuse_frame_detector.h File webrtc/video_engine/overuse_frame_detector.h (right): https://codereview.chromium.org/1481723003/diff/1/webrtc/video_engine/overuse_frame_detector.h#newcode53 webrtc/video_engine/overuse_frame_detector.h:53: int high_encode_usage_threshold_percent; // Threshold for triggering overuse. On 2015/11/26 ...
5 years ago (2015-11-26 14:04:45 UTC) #5
phoglund_chromium
lgtm
5 years ago (2015-11-26 14:10:03 UTC) #7
pbos
lgtm
5 years ago (2015-11-26 14:14:16 UTC) #8
kjellander_webrtc
On 2015/11/26 14:14:16, pbos wrote: > lgtm Not sure why this was sent with the ...
5 years ago (2015-11-26 14:24:14 UTC) #10
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 0fcaf99b716c71e721db25f37f62dabf5dcbe69a (presubmit successful).
5 years ago (2015-11-26 14:25:10 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-26 14:25:12 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0fcaf99b716c71e721db25f37f62dabf5dcbe69a
Cr-Commit-Position: refs/heads/master@{#10808}

Powered by Google App Engine
This is Rietveld 408576698