Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 1481493004: audio_coding: remove "main" directory (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

audio_coding: remove "main" directory This is the last piece of the old directory layout of the modules. Duplicated header files are left in audio_coding/main/include until downstream code is updated to the new location. They have pragma warnings added to them and identical header guards as the new headers to avoid breaking things. BUG=webrtc:5095 TESTED=Passing compile-trybots with --clobber flag: git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/3e6db2321ccdc8738c9cecbe9bdab13d4f0f658d Cr-Commit-Position: refs/heads/master@{#10803}

Patch Set 1 #

Patch Set 2 : Remove pointless OWNERS file #

Patch Set 3 : Updated BUILD.gn file #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -16491 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 2 chunks +21 lines, -21 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_codec_database.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_codec_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_common_defs.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_neteq_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receiver.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receiver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_resampler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_resampler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/call_statistics.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/call_statistics.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/call_statistics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/codec_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/codec_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/codec_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/initial_delay_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/initial_delay_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/initial_delay_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/acm2/rent_a_codec.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_coding.gypi View 1 chunk +184 lines, -1 line 0 comments Download
A + webrtc/modules/audio_coding/include/audio_coding_module.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc View 1 chunk +0 lines, -331 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_common_defs.h View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_neteq_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receive_test_oldapi.cc View 1 chunk +0 lines, -221 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receiver.h View 1 chunk +0 lines, -305 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 1 chunk +0 lines, -540 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_receiver_unittest_oldapi.cc View 1 chunk +0 lines, -369 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_resampler.h View 1 chunk +0 lines, -39 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_resampler.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_send_test_oldapi.h View 1 chunk +0 lines, -91 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/acm_send_test_oldapi.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h View 1 chunk +0 lines, -280 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc View 1 chunk +0 lines, -786 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/audio_coding_module_unittest_oldapi.cc View 1 chunk +0 lines, -1777 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/call_statistics.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/call_statistics.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/call_statistics_unittest.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/codec_manager.h View 1 chunk +0 lines, -81 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 1 chunk +0 lines, -313 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/codec_manager_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/initial_delay_manager.h View 1 chunk +0 lines, -120 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/initial_delay_manager.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/initial_delay_manager_unittest.cc View 1 chunk +0 lines, -376 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/rent_a_codec.h View 1 chunk +0 lines, -249 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D webrtc/modules/audio_coding/main/acm2/rent_a_codec_unittest.cc View 1 chunk +0 lines, -209 lines 0 comments Download
D webrtc/modules/audio_coding/main/audio_coding_module.gypi View 1 chunk +0 lines, -196 lines 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module.h View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h View 2 chunks +5 lines, -3 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/ACMTest.h View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/APITest.h View 1 chunk +0 lines, -163 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/APITest.cc View 1 chunk +0 lines, -1114 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/Channel.h View 1 chunk +0 lines, -130 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/Channel.cc View 1 chunk +0 lines, -424 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/EncodeDecodeTest.h View 1 chunk +0 lines, -123 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/EncodeDecodeTest.cc View 1 chunk +0 lines, -351 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/PCMFile.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/PCMFile.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/PacketLossTest.h View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/PacketLossTest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/RTPFile.h View 1 chunk +0 lines, -126 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/RTPFile.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/SpatialAudio.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/SpatialAudio.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestAllCodecs.h View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestAllCodecs.cc View 1 chunk +0 lines, -485 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestRedFec.h View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestRedFec.cc View 1 chunk +0 lines, -476 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestStereo.h View 1 chunk +0 lines, -117 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestStereo.cc View 1 chunk +0 lines, -838 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestVADDTX.h View 1 chunk +0 lines, -102 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TestVADDTX.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/Tester.cc View 1 chunk +0 lines, -171 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TimedTrace.h View 1 chunk +0 lines, -36 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TimedTrace.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TwoWayCommunication.h View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/TwoWayCommunication.cc View 1 chunk +0 lines, -299 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/delay_test.cc View 1 chunk +0 lines, -265 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/iSACTest.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/iSACTest.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/insert_packet_with_timing.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/opus_test.h View 1 chunk +0 lines, -57 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/opus_test.cc View 1 chunk +0 lines, -380 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/target_delay_unittest.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/utility.h View 1 chunk +0 lines, -139 lines 0 comments Download
D webrtc/modules/audio_coding/main/test/utility.cc View 1 chunk +0 lines, -303 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/nack.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/nack_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/test/ACMTest.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/APITest.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_coding/test/APITest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/Channel.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/Channel.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/test/EncodeDecodeTest.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + webrtc/modules/audio_coding/test/EncodeDecodeTest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/PCMFile.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/PCMFile.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/audio_coding/test/PacketLossTest.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/PacketLossTest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/test/RTPFile.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/RTPFile.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/audio_coding/test/SpatialAudio.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_coding/test/SpatialAudio.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/audio_coding/test/TestAllCodecs.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestAllCodecs.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestRedFec.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestRedFec.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestStereo.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestStereo.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestVADDTX.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TestVADDTX.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/Tester.cc View 1 chunk +11 lines, -11 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TimedTrace.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TimedTrace.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TwoWayCommunication.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/test/delay_test.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + webrtc/modules/audio_coding/test/iSACTest.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_coding/test/iSACTest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/insert_packet_with_timing.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/modules/audio_coding/test/opus_test.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + webrtc/modules/audio_coding/test/opus_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/target_delay_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/modules/audio_coding/test/utility.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/modules/audio_coding/test/utility.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +24 lines, -24 lines 0 comments Download
M webrtc/modules/utility/source/coder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voice_engine_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
kjellander_webrtc
3 years, 8 months ago (2015-11-25 22:34:10 UTC) #5
kwiberg-webrtc
lgtm hlundin@, I know you wanted to get rid of the "acm2" subdirectory too (along ...
3 years, 8 months ago (2015-11-26 10:51:54 UTC) #6
hlundin-webrtc
lgtm But as kwiberg says, I'd like to get rid of the acm2 layer too. ...
3 years, 8 months ago (2015-11-26 12:32:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481493004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481493004/60001
3 years, 8 months ago (2015-11-26 12:44:09 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 8 months ago (2015-11-26 12:44:59 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2015-11-26 12:45:07 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3e6db2321ccdc8738c9cecbe9bdab13d4f0f658d
Cr-Commit-Position: refs/heads/master@{#10803}

Powered by Google App Engine
This is Rietveld 408576698