Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1480233003: Initialize type_preference_ in TestPort. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
åsapersson, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Initialize type_preference_ in TestPort. Prevents use of undefined memory for logging during PortTest.TestLoopbackCal which was recently enabled for all release builds. BUG= R=asapersson@webrtc.org TBR=pthatcher@webrtc.org Committed: https://crrev.com/7640ffabd74a79bf4b40688a4b664950a846e989 Cr-Commit-Position: refs/heads/master@{#10842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/p2p/base/port_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
åsapersson
lgtm
5 years ago (2015-11-30 16:06:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480233003/1
5 years ago (2015-11-30 16:07:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 17:17:02 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-30 17:17:16 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7640ffabd74a79bf4b40688a4b664950a846e989
Cr-Commit-Position: refs/heads/master@{#10842}

Powered by Google App Engine
This is Rietveld 408576698