Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding.h

Issue 1479793002: Remove RegisterExternal{De,En}coder error codes. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 // Register an external encoder object. This can not be used together with 174 // Register an external encoder object. This can not be used together with
175 // external decoder callbacks. 175 // external decoder callbacks.
176 // 176 //
177 // Input: 177 // Input:
178 // - externalEncoder : Encoder object to be used for encoding frames in serted 178 // - externalEncoder : Encoder object to be used for encoding frames in serted
179 // with the AddVideoFrame API. 179 // with the AddVideoFrame API.
180 // - payloadType : The payload type bound which this encoder is bou nd to. 180 // - payloadType : The payload type bound which this encoder is bou nd to.
181 // 181 //
182 // Return value : VCM_OK, on success. 182 // Return value : VCM_OK, on success.
183 // < 0, on error. 183 // < 0, on error.
184 // TODO(pbos): Remove return type when unused elsewhere.
184 virtual int32_t RegisterExternalEncoder(VideoEncoder* externalEncoder, 185 virtual int32_t RegisterExternalEncoder(VideoEncoder* externalEncoder,
185 uint8_t payloadType, 186 uint8_t payloadType,
186 bool internalSource = false) = 0; 187 bool internalSource = false) = 0;
187 188
188 // API to get currently configured encoder target bitrate in bits/s. 189 // API to get currently configured encoder target bitrate in bits/s.
189 // 190 //
190 // Return value : 0, on success. 191 // Return value : 0, on success.
191 // < 0, on error. 192 // < 0, on error.
192 virtual int Bitrate(unsigned int* bitrate) const = 0; 193 virtual int Bitrate(unsigned int* bitrate) const = 0;
193 194
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // Register an externally defined decoder/renderer object. Can be a decoder only or a 328 // Register an externally defined decoder/renderer object. Can be a decoder only or a
328 // decoder coupled with a renderer. Note that RegisterReceiveCodec must be c alled to 329 // decoder coupled with a renderer. Note that RegisterReceiveCodec must be c alled to
329 // be used for decoding incoming streams. 330 // be used for decoding incoming streams.
330 // 331 //
331 // Input: 332 // Input:
332 // - externalDecoder : The external decoder/renderer object. 333 // - externalDecoder : The external decoder/renderer object.
333 // - payloadType : The payload type which this decoder shoul d be 334 // - payloadType : The payload type which this decoder shoul d be
334 // registered to. 335 // registered to.
335 // - internalRenderTiming : True if the internal renderer (if any) of the decoder 336 // - internalRenderTiming : True if the internal renderer (if any) of the decoder
336 // object can make sure to render at a given time in ms. 337 // object can make sure to render at a given time in ms.
337 // 338 virtual void RegisterExternalDecoder(VideoDecoder* externalDecoder,
338 // Return value : VCM_OK, on success. 339 uint8_t payloadType,
339 // < 0, on error. 340 bool internalRenderTiming) = 0;
340 virtual int32_t RegisterExternalDecoder(VideoDecoder* externalDecoder,
341 uint8_t payloadType,
342 bool internalRenderTiming) = 0;
343 341
344 // Register a receive callback. Will be called whenever there is a new frame ready 342 // Register a receive callback. Will be called whenever there is a new frame ready
345 // for rendering. 343 // for rendering.
346 // 344 //
347 // Input: 345 // Input:
348 // - receiveCallback : The callback object to be used by the mod ule when a 346 // - receiveCallback : The callback object to be used by the mod ule when a
349 // frame is ready for rendering. 347 // frame is ready for rendering.
350 // De-register with a NULL pointer. 348 // De-register with a NULL pointer.
351 // 349 //
352 // Return value : VCM_OK, on success. 350 // Return value : VCM_OK, on success.
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 EncodedImageCallback* observer) = 0; 533 EncodedImageCallback* observer) = 0;
536 virtual void RegisterPostEncodeImageCallback( 534 virtual void RegisterPostEncodeImageCallback(
537 EncodedImageCallback* post_encode_callback) = 0; 535 EncodedImageCallback* post_encode_callback) = 0;
538 // Releases pending decode calls, permitting faster thread shutdown. 536 // Releases pending decode calls, permitting faster thread shutdown.
539 virtual void TriggerDecoderShutdown() = 0; 537 virtual void TriggerDecoderShutdown() = 0;
540 }; 538 };
541 539
542 } // namespace webrtc 540 } // namespace webrtc
543 541
544 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_ 542 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/codec_database.cc ('k') | webrtc/modules/video_coding/video_coding_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698