Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1479563004: VideoCapturerAndroid - allow lower frame rate in bad lighning (Closed)

Created:
5 years ago by perkj_webrtc
Modified:
5 years ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid - allow lower frame rate in bad lightning Insted of using a fixed frame rate, we allow the camera to use a lower frame rate. The camera will choose depending on lightning condition. TESTED= In a room with low light on N5, N6 N7, Galaxy 4. BUG=webrtc:5262 R=magjed@webrtc.org Committed: https://crrev.com/727dbc2968c8761a3150faebba254155fb042530 Cr-Commit-Position: refs/heads/master@{#10807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
perkj_webrtc
5 years ago (2015-11-26 12:39:59 UTC) #3
perkj_webrtc
Please?
5 years ago (2015-11-26 12:40:08 UTC) #4
magjed_webrtc
lgtm. ship it!
5 years ago (2015-11-26 13:16:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479563004/1
5 years ago (2015-11-26 13:27:47 UTC) #8
perkj_webrtc
Committed patchset #1 (id:1) manually as 727dbc2968c8761a3150faebba254155fb042530 (presubmit successful).
5 years ago (2015-11-26 14:15:54 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 14:16:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/727dbc2968c8761a3150faebba254155fb042530
Cr-Commit-Position: refs/heads/master@{#10807}

Powered by Google App Engine
This is Rietveld 408576698