Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1479183002:
Default to LS_INFO logging for release builds. (Closed)
|
Created:
5 years ago by pbos-webrtc Modified:
5 years ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDefault to LS_INFO logging for release builds.
Increases default loglevel for test targets to LS_INFO, which is a no-op
for debug builds but increases logging on release builds.
This is to present better debug info on buildbots when test runs fail.
BUG=
R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org
Committed: https://chromium.googlesource.com/external/webrtc/+/def58203a15a6f8506df6bb4eccc44c004ff2211
Patch Set 1 #Patch Set 2 : add null terminator to AEGetDescData #Patch Set 3 : as std::string instead #Patch Set 4 : without typo #Patch Set 5 : without overflow #
Messages
Total messages: 28 (11 generated)
Description was changed from ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for Debug builds but increases logging on Release builds. BUG= R=kjellander@webrtc.org, stefan@webrtc.org ========== to ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. BUG= R=kjellander@webrtc.org, stefan@webrtc.org ==========
PTAL
lgtm if this is how it's done (not really familiar with the logging code).
lgtm too, if this is how it is done... :)
pbos@webrtc.org changed reviewers: + henrikg@webrtc.org
+R henrikg@ for base
Description was changed from ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. BUG= R=kjellander@webrtc.org, stefan@webrtc.org ========== to ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org ==========
Code is fine. Doing this is probably good - I'm not familiar with why this logging level is needed in tests. Can you please explain that in the description? Or even better file a bug. lgtm.
Description was changed from ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org ========== to ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. This is to present better debug info on buildbots when test runs fail. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org ==========
On 2015/11/27 12:54:44, Henrik Grunell (webrtc) wrote: > Code is fine. Doing this is probably good - I'm not familiar with why this > logging level is needed in tests. Can you please explain that in the > description? Or even better file a bug. > > lgtm. Added "This is to present better debug info on buildbots when test runs fail."
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479183002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/10915)
The CQ bit was checked by pbos@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479183002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/10920)
add null terminator to AEGetDescData
as std::string instead
without typo
without overflow
Message was sent while issue was closed.
Description was changed from ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. This is to present better debug info on buildbots when test runs fail. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org ========== to ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. This is to present better debug info on buildbots when test runs fail. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/def58203a15a6f8506df6bb4eccc44c004ff2211 Cr-Commit-Position: refs/heads/master@{#10826} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/def58203a15a6f8506df6bb4eccc44c004ff2211 Cr-Commit-Position: refs/heads/master@{#10826}
Message was sent while issue was closed.
Description was changed from ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. This is to present better debug info on buildbots when test runs fail. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/def58203a15a6f8506df6bb4eccc44c004ff2211 Cr-Commit-Position: refs/heads/master@{#10826} ========== to ========== Default to LS_INFO logging for release builds. Increases default loglevel for test targets to LS_INFO, which is a no-op for debug builds but increases logging on release builds. This is to present better debug info on buildbots when test runs fail. BUG= R=henrikg@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/def58203a15a6f8506df6bb4e... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as def58203a15a6f8506df6bb4eccc44c004ff2211 (presubmit successful).
Message was sent while issue was closed.
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
Message was sent while issue was closed.
what's the impact of this for release builds? (e.g. for Chrome) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
