Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Unified Diff: webrtc/video_engine/vie_channel.h

Issue 1478253002: Add histogram stats for send delay for a sent video stream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_engine/vie_channel.h
diff --git a/webrtc/video_engine/vie_channel.h b/webrtc/video_engine/vie_channel.h
index 17b56cadd285fe5bc24b6ef32319ade92a837a5a..c9739fb8083a3069155ed6b218a6a9efc5e2113c 100644
--- a/webrtc/video_engine/vie_channel.h
+++ b/webrtc/video_engine/vie_channel.h
@@ -188,6 +188,8 @@ class ViEChannel : public VCMFrameTypeCallback,
void RegisterSendSideDelayObserver(SendSideDelayObserver* observer);
+ void RegisterSendPacketObserver(SendPacketObserver* observer);
+
// Called on any new send bitrate estimate.
void RegisterSendBitrateObserver(BitrateStatisticsObserver* observer);
@@ -305,6 +307,7 @@ class ViEChannel : public VCMFrameTypeCallback,
BitrateStatisticsObserver* send_bitrate_observer,
FrameCountObserver* send_frame_count_observer,
SendSideDelayObserver* send_side_delay_observer,
+ SendPacketObserver* send_packet_observer,
size_t num_modules);
// Assumed to be protected.
@@ -381,6 +384,17 @@ class ViEChannel : public VCMFrameTypeCallback,
}
} send_side_delay_observer_;
+ class RegisterableSendPacketObserver
pbos-webrtc 2015/12/07 06:05:52 Can this be set on construction instead so that we
åsapersson 2015/12/08 12:50:15 Followed the current setup. Maybe do the setup cha
+ : public RegisterableCallback<SendPacketObserver> {
+ void OnSendPacket(uint16_t packet_id,
+ int64_t capture_time_ms,
+ uint32_t ssrc) override {
+ CriticalSectionScoped cs(critsect_.get());
+ if (callback_)
+ callback_->OnSendPacket(packet_id, capture_time_ms, ssrc);
+ }
+ } send_packet_observer_;
+
class RegisterableRtcpPacketTypeCounterObserver
: public RegisterableCallback<RtcpPacketTypeCounterObserver> {
public:

Powered by Google App Engine
This is Rietveld 408576698