Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 1478253002: Add histogram stats for send delay for a sent video stream. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2038 matching lines...) Expand 10 before | Expand all | Expand 10 after
2049 EXPECT_EQ(1, test::NumHistogramSamples( 2049 EXPECT_EQ(1, test::NumHistogramSamples(
2050 "WebRTC.Video.PaddingBitrateReceivedInKbps")); 2050 "WebRTC.Video.PaddingBitrateReceivedInKbps"));
2051 EXPECT_EQ(1, test::NumHistogramSamples( 2051 EXPECT_EQ(1, test::NumHistogramSamples(
2052 "WebRTC.Video.RetransmittedBitrateSentInKbps")); 2052 "WebRTC.Video.RetransmittedBitrateSentInKbps"));
2053 EXPECT_EQ(1, test::NumHistogramSamples( 2053 EXPECT_EQ(1, test::NumHistogramSamples(
2054 "WebRTC.Video.RetransmittedBitrateReceivedInKbps")); 2054 "WebRTC.Video.RetransmittedBitrateReceivedInKbps"));
2055 2055
2056 EXPECT_EQ(1, test::NumHistogramSamples(video_prefix + "SendSideDelayInMs")); 2056 EXPECT_EQ(1, test::NumHistogramSamples(video_prefix + "SendSideDelayInMs"));
2057 EXPECT_EQ(1, 2057 EXPECT_EQ(1,
2058 test::NumHistogramSamples(video_prefix + "SendSideDelayMaxInMs")); 2058 test::NumHistogramSamples(video_prefix + "SendSideDelayMaxInMs"));
2059 EXPECT_EQ(1, test::NumHistogramSamples(video_prefix + "SendDelayInMs"));
stefan-webrtc 2015/12/10 08:37:50 Shouldn't we just remove the SendSideDelayInMs abo
åsapersson 2015/12/15 14:28:27 SendSideDelayInMs is currently the delay from capt
2059 2060
2060 int num_rtx_samples = use_rtx ? 1 : 0; 2061 int num_rtx_samples = use_rtx ? 1 : 0;
2061 EXPECT_EQ(num_rtx_samples, test::NumHistogramSamples( 2062 EXPECT_EQ(num_rtx_samples, test::NumHistogramSamples(
2062 "WebRTC.Video.RtxBitrateSentInKbps")); 2063 "WebRTC.Video.RtxBitrateSentInKbps"));
2063 EXPECT_EQ(num_rtx_samples, test::NumHistogramSamples( 2064 EXPECT_EQ(num_rtx_samples, test::NumHistogramSamples(
2064 "WebRTC.Video.RtxBitrateReceivedInKbps")); 2065 "WebRTC.Video.RtxBitrateReceivedInKbps"));
2065 2066
2066 int num_red_samples = use_red ? 1 : 0; 2067 int num_red_samples = use_red ? 1 : 0;
2067 EXPECT_EQ(num_red_samples, test::NumHistogramSamples( 2068 EXPECT_EQ(num_red_samples, test::NumHistogramSamples(
2068 "WebRTC.Video.FecBitrateSentInKbps")); 2069 "WebRTC.Video.FecBitrateSentInKbps"));
(...skipping 1154 matching lines...) Expand 10 before | Expand all | Expand 10 after
3223 EXPECT_TRUE(default_receive_config.rtp.rtx.empty()) 3224 EXPECT_TRUE(default_receive_config.rtp.rtx.empty())
3224 << "Enabling RTX requires rtpmap: rtx negotiation."; 3225 << "Enabling RTX requires rtpmap: rtx negotiation.";
3225 EXPECT_TRUE(default_receive_config.rtp.extensions.empty()) 3226 EXPECT_TRUE(default_receive_config.rtp.extensions.empty())
3226 << "Enabling RTP extensions require negotiation."; 3227 << "Enabling RTP extensions require negotiation.";
3227 3228
3228 VerifyEmptyNackConfig(default_receive_config.rtp.nack); 3229 VerifyEmptyNackConfig(default_receive_config.rtp.nack);
3229 VerifyEmptyFecConfig(default_receive_config.rtp.fec); 3230 VerifyEmptyFecConfig(default_receive_config.rtp.fec);
3230 } 3231 }
3231 3232
3232 } // namespace webrtc 3233 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698