Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1477423002: audio_coding: Cleanup duplicated headers after "main" removal. (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

audio_coding: Cleanup duplicated headers after "main" removal. In https://codereview.webrtc.org/1481493004/ some duplicated headers were left to make it possible to update downstream without breakage. Now that's done and we can remove these to avoid confusion. BUG=webrtc:5095 TBR=henrik.lundin@webrtc.org, kwiberg@webrtc.org TESTED=Passing compile-trybots with --clobber flag: git cl try --clobber --bot=win_compile_rel --bot=linux_compile_rel --bot=android_compile_rel --bot=mac_compile_rel --bot=ios_rel --bot=linux_gn_rel --bot=win_x64_gn_rel --bot=mac_x64_gn_rel --bot=android_gn_rel -m tryserver.webrtc NOTRY=True Committed: https://crrev.com/19822d63c1162c0989bc60b524db8c5c27815f72 Cr-Commit-Position: refs/heads/master@{#10829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -796 lines) Patch
D webrtc/modules/audio_coding/main/include/audio_coding_module.h View 1 chunk +0 lines, -743 lines 0 comments Download
D webrtc/modules/audio_coding/main/include/audio_coding_module_typedefs.h View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
kjellander_webrtc
TBRing this to get it out of the way (and reduce the risk of someone ...
5 years ago (2015-11-27 18:54:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477423002/1
5 years ago (2015-11-27 18:54:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 18:55:48 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19822d63c1162c0989bc60b524db8c5c27815f72 Cr-Commit-Position: refs/heads/master@{#10829}
5 years ago (2015-11-27 18:55:59 UTC) #11
kwiberg-webrtc
lgtm
5 years ago (2015-11-28 09:33:23 UTC) #12
hlundin-webrtc
5 years ago (2015-11-30 09:23:22 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698