webrtc/modules/audio_device/test/audio_device_test_api.cc - Issue 1477013005: Replace RefCountImpl with rtc::RefCountedObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/test/audio_device_test_api.cc

Issue 1477013005: Replace RefCountImpl with rtc::RefCountedObject. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/include/audio_device.h ('k') | webrtc/modules/desktop_capture/differ_block_unittest.cc » ('j') | webrtc/modules/video_capture/ios/video_capture_ios.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/test/audio_device_test_api.cc

diff --git a/webrtc/modules/audio_device/test/audio_device_test_api.cc b/webrtc/modules/audio_device/test/audio_device_test_api.cc

index f36a049ffc7ffe079b80a4494026ceba1926ac2a..e869c54230df45a52fadd929a6f5189039e55359 100644

--- a/webrtc/modules/audio_device/test/audio_device_test_api.cc

+++ b/webrtc/modules/audio_device/test/audio_device_test_api.cc

@@ -46,7 +46,7 @@ using namespace webrtc;

class AudioEventObserverAPI: public AudioDeviceObserver {

public:

- AudioEventObserverAPI(AudioDeviceModule* audioDevice)

+ AudioEventObserverAPI(rtc::scoped_refptr<AudioDeviceModule> audioDevice)

tommi 2016/01/07 16:41:40 const& otherwise we're adding calls to AddRef/Rel

pbos-webrtc 2016/01/07 17:23:16 Done.

: error_(kRecordingError),

warning_(kRecordingWarning),

audio_device_(audioDevice) {

@@ -70,7 +70,7 @@ class AudioEventObserverAPI: public AudioDeviceObserver {

ErrorCode error_;

WarningCode warning_;

private:

- AudioDeviceModule* audio_device_;

+ rtc::scoped_refptr<AudioDeviceModule> audio_device_;

};

class AudioTransportAPI: public AudioTransport {