Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1477013003: Build/use constructormagic.h unconditionally. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Build/use constructormagic.h unconditionally. These macros no longer collide with Chromium since they are prefixed with RTC_. BUG= R=henrikg@webrtc.org Committed: https://crrev.com/fd5dae395b8aa45c103671462af51aaa98cd8303 Cr-Commit-Position: refs/heads/master@{#10801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pbos-webrtc
PTAL
5 years ago (2015-11-26 11:48:16 UTC) #1
Henrik Grunell WebRTC
lgtm
5 years ago (2015-11-26 11:53:36 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as fd5dae395b8aa45c103671462af51aaa98cd8303 (presubmit successful).
5 years ago (2015-11-26 11:54:37 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-26 11:54:41 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd5dae395b8aa45c103671462af51aaa98cd8303
Cr-Commit-Position: refs/heads/master@{#10801}

Powered by Google App Engine
This is Rietveld 408576698