Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1476743002: Move the FEC enabling logic from CodecManager to Rent-A-Codec (Closed)

Created:
5 years ago by kwiberg-webrtc
Modified:
5 years ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@rac0
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move the FEC enabling logic from CodecManager to Rent-A-Codec BUG=webrtc:5028 Committed: https://crrev.com/9cd5c8ca79dbfaecb6101e0635b9cb8699875784 Cr-Commit-Position: refs/heads/master@{#10785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M webrtc/modules/audio_coding/main/acm2/codec_manager.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/rent_a_codec_unittest.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1473563004 Patch 1

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
5 years ago (2015-11-25 02:49:43 UTC) #3
hlundin-webrtc
lgtm
5 years ago (2015-11-25 08:59:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476743002/1
5 years ago (2015-11-25 09:21:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:25:09 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-25 09:25:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9cd5c8ca79dbfaecb6101e0635b9cb8699875784
Cr-Commit-Position: refs/heads/master@{#10785}

Powered by Google App Engine
This is Rietveld 408576698