webrtc/modules/audio_device/linux/audio_device_pulse_linux.h - Issue 1476453002: Clean up PlatformThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

Issue 1476453002: Clean up PlatformThread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: IsRunning DCHECK Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

diff --git a/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h b/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

index 263d42da3af7c58f8c5cd3ff375f172304ded11b..de8df0be1bae369b5ccf4cfd638da4c185230d95 100644

--- a/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

+++ b/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

@@ -284,8 +284,9 @@ private:

EventWrapper& _recStartEvent;

EventWrapper& _playStartEvent;

- rtc::scoped_ptr<PlatformThread> _ptrThreadPlay;

- rtc::scoped_ptr<PlatformThread> _ptrThreadRec;

+ // TODO(pbos): Remove scoped_ptr and use directly without resetting.

+ rtc::scoped_ptr<rtc::PlatformThread> _ptrThreadPlay;

+ rtc::scoped_ptr<rtc::PlatformThread> _ptrThreadRec;

int32_t _id;

AudioMixerManagerLinuxPulse _mixerManager;