Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1475643010: Add symlink to src/third_party/libc++-static (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add symlink to src/third_party/libc++-static This is used on Mac to link against a precompiled libc++ library on Mac (see https://crbug.com/400091 for details) TBR=tkchin@webrtc.org TESTED=Verified the warnings like: ld: warning: directory not found for option '-L../../third_party/libc++-static' are no longer printed on Mac. Committed: https://crrev.com/26ab91b73fa1a2628a5cc049f29bb52926e230ba Cr-Commit-Position: refs/heads/master@{#10797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M setup_links.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
5 years ago (2015-11-26 09:26:14 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as 26ab91b73fa1a2628a5cc049f29bb52926e230ba (presubmit successful).
5 years ago (2015-11-26 09:26:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/26ab91b73fa1a2628a5cc049f29bb52926e230ba Cr-Commit-Position: refs/heads/master@{#10797}
5 years ago (2015-11-26 09:26:49 UTC) #7
tkchin_webrtc
5 years ago (2015-11-26 15:35:35 UTC) #8
Message was sent while issue was closed.
On 2015/11/26 09:26:49, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/26ab91b73fa1a2628a5cc049f29bb52926e230ba
> Cr-Commit-Position: refs/heads/master@{#10797}

lgtm thanks!

Powered by Google App Engine
This is Rietveld 408576698