Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1474623002: Set mac_deployment_target default to 10.7 (Closed)

Created:
5 years, 1 month ago by kjellander (google.com)
Modified:
5 years ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set mac_deployment_target default to 10.7 This overrides the default (10.6) in Chromium's build/common.gypi. It's needed since we want ARC and libc++. TESTED=Ran webrtc/build/gyp_webrtc before this patch and then grep -r macosx-version-min out/Debug/* | grep 10.6 which gave a lot of output. Then with this patch applied, there were no output for 10.6 (only 10.7). R=tkchin@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/46a491bcbb887c7019cbd87cc85429703a69c387

Patch Set 1 #

Patch Set 2 : Don't set if already set #

Patch Set 3 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M webrtc/supplement.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkchin_webrtc
On 2015/11/24 06:58:38, kjellander (webrtc) wrote: > mailto:kjellander@webrtc.org changed reviewers: > + mailto:tkchin@webrtc.org lgtm just ...
5 years ago (2015-11-24 22:55:19 UTC) #3
kjellander_webrtc
On 2015/11/24 22:55:19, tkchin_webrtc wrote: > On 2015/11/24 06:58:38, kjellander (webrtc) wrote: > > mailto:kjellander@webrtc.org ...
5 years ago (2015-11-25 07:29:11 UTC) #4
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/46a491bcbb887c7019cbd87cc85429703a69c387 Cr-Commit-Position: refs/heads/master@{#10783}
5 years ago (2015-11-25 07:35:14 UTC) #5
kjellander (google.com)
5 years ago (2015-11-25 07:35:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
46a491bcbb887c7019cbd87cc85429703a69c387.

Powered by Google App Engine
This is Rietveld 408576698