Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 1474363002: Use webrtc/base/logging.h for voice_engine. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use webrtc/base/logging.h for voice_engine. BUG=webrtc:5118 R=henrika@webrtc.org Committed: https://crrev.com/ad856229a796a8efa1126ef8aa8d238f2b0a2b21 Cr-Commit-Position: refs/heads/master@{#10827}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ist -> dst #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M webrtc/voice_engine/channel.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/voice_engine/utility.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 5 chunks +1 line, -6 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/voice_engine/voe_network_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
pbos-webrtc
PTAL, I removed LS_VERBOSE logging which includes the API logs.
5 years ago (2015-11-27 16:34:46 UTC) #1
henrika_webrtc
LGTM BTW, have you figured out why we don't see these logs if they come ...
5 years ago (2015-11-27 16:44:50 UTC) #2
henrika_webrtc
https://codereview.webrtc.org/1474363002/diff/1/webrtc/voice_engine/utility.cc File webrtc/voice_engine/utility.cc (right): https://codereview.webrtc.org/1474363002/diff/1/webrtc/voice_engine/utility.cc#newcode56 webrtc/voice_engine/utility.cc:56: << sample_rate_hz << ", ist_frame->sample_rate_hz_ = " ist -> ...
5 years ago (2015-11-27 16:44:58 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1474363002/diff/1/webrtc/voice_engine/utility.cc File webrtc/voice_engine/utility.cc (right): https://codereview.webrtc.org/1474363002/diff/1/webrtc/voice_engine/utility.cc#newcode56 webrtc/voice_engine/utility.cc:56: << sample_rate_hz << ", ist_frame->sample_rate_hz_ = " On 2015/11/27 ...
5 years ago (2015-11-27 16:49:35 UTC) #4
pbos-webrtc
On 2015/11/27 16:44:50, henrika_webrtc wrote: > LGTM > > BTW, have you figured out why ...
5 years ago (2015-11-27 16:50:21 UTC) #5
pbos-webrtc
ist -> dst
5 years ago (2015-11-27 16:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474363002/20001
5 years ago (2015-11-27 16:51:06 UTC) #9
henrika_webrtc
Yes, I was using base/logging.h.
5 years ago (2015-11-27 16:55:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 17:48:40 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-27 17:48:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad856229a796a8efa1126ef8aa8d238f2b0a2b21
Cr-Commit-Position: refs/heads/master@{#10827}

Powered by Google App Engine
This is Rietveld 408576698