Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1474193002: Call InitDecode with proper resolution. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, noahric, Pawel Osciak
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Call InitDecode with proper resolution. Prevents double-initialization of decoders due to resolution changes between initial database settings and first incoming frame. BUG=webrtc:5251 R=mflodman@webrtc.org Committed: https://crrev.com/e997a7de1419c447d46cfc230111deffcbdfab19 Cr-Commit-Position: refs/heads/master@{#10822}

Patch Set 1 #

Patch Set 2 : best-effort width/height setting #

Total comments: 2

Patch Set 3 : nullptr woo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -29 lines) Patch
M webrtc/modules/video_coding/codec_database.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 2 13 chunks +36 lines, -25 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
pbos-webrtc
PTAL, woo! This prevents initializing Android MediaEncoder twice. I haven't checked impact on software coders, ...
5 years ago (2015-11-26 16:20:42 UTC) #1
pbos-webrtc
best-effort width/height setting
5 years ago (2015-11-26 16:37:06 UTC) #2
pbos-webrtc
There, had bug due to zero-resolutions in input frames.
5 years ago (2015-11-26 16:38:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474193002/20001
5 years ago (2015-11-26 16:38:44 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-26 18:39:03 UTC) #7
mflodman
One comment, then LGTM. https://codereview.webrtc.org/1474193002/diff/20001/webrtc/modules/video_coding/codec_database.cc File webrtc/modules/video_coding/codec_database.cc (right): https://codereview.webrtc.org/1474193002/diff/20001/webrtc/modules/video_coding/codec_database.cc#newcode599 webrtc/modules/video_coding/codec_database.cc:599: return nullptr; I'd prefer to ...
5 years ago (2015-11-27 09:20:22 UTC) #9
pbos-webrtc
nullptr woo
5 years ago (2015-11-27 10:49:43 UTC) #10
pbos-webrtc
Committed patchset #3 (id:40001) manually as e997a7de1419c447d46cfc230111deffcbdfab19 (presubmit successful).
5 years ago (2015-11-27 13:23:36 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e997a7de1419c447d46cfc230111deffcbdfab19 Cr-Commit-Position: refs/heads/master@{#10822}
5 years ago (2015-11-27 13:23:37 UTC) #15
pbos-webrtc
5 years ago (2015-11-27 13:23:41 UTC) #16
Message was sent while issue was closed.
https://codereview.webrtc.org/1474193002/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codec_database.cc (right):

https://codereview.webrtc.org/1474193002/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codec_database.cc:599: return nullptr;
On 2015/11/27 09:20:21, mflodman wrote:
> I'd prefer to use NULL or nullptr, not mix both in the same file. And of the
two
> I of course I do prefer nullptr ;)

Done.

Powered by Google App Engine
This is Rietveld 408576698