Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1473983002:
Fix root_files WATCHLIST. (Closed)
|
Created:
5 years ago by Andrew MacDonald Modified:
5 years ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, qiang.lu, niklas.enbom, peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix root_files WATCHLIST.
The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc.
Also modify my subscriptions a bit.
R=kjellander@webrtc.org
TEST=verified with depot_tools/watchlists.py
NOTRY=true
Committed: https://crrev.com/6e40c09fc051fa53fc8a56adb31f6232577eb9d2
Cr-Commit-Position: refs/heads/master@{#10813}
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 23 (13 generated)
Description was changed from ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org ========== to ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py ==========
lgtm
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473983002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/build...) android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...) android_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/7161) android_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/7248) ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/9675) linux_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/build...) linux_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_dbg/builds/7041) linux_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/7030) linux_msan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/6212) linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/8263) presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/1986)
The CQ bit was checked by andrew@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/1473983002/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473983002/20001
The CQ bit was unchecked by andrew@webrtc.org
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473983002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py ========== to ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org NOTRY=true TEST=verified with depot_tools/watchlists.py ==========
Description was changed from ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org NOTRY=true TEST=verified with depot_tools/watchlists.py ========== to ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py NOTRY=true ==========
The CQ bit was checked by andrew@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473983002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py NOTRY=true ========== to ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py NOTRY=true ========== to ========== Fix root_files WATCHLIST. The webrtc/ rule required a ^ to avoid matching e.g. talk/app/webrtc. Also modify my subscriptions a bit. R=kjellander@webrtc.org TEST=verified with depot_tools/watchlists.py NOTRY=true Committed: https://crrev.com/6e40c09fc051fa53fc8a56adb31f6232577eb9d2 Cr-Commit-Position: refs/heads/master@{#10813} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6e40c09fc051fa53fc8a56adb31f6232577eb9d2 Cr-Commit-Position: refs/heads/master@{#10813} |
