Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1473733004: Revert of Created a test that reports the statistics for the duration of APM stream processing ... (Closed)

Created:
5 years ago by kjellander_webrtc
Modified:
5 years ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Created a test that reports the statistics for the duration of APM stream processing API calls. (patchset #15 id:280001 of https://codereview.webrtc.org/1436553004/ ) Reason for revert: This breaks the Win32 Release [large tests] bot (webrtc_perf_tests times out after 1h23m): https://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D The Mac64 Release [large tests] bot's runtime also increased with +20 minutes. These bot configs are not a part of the default trybot set, so please run them manually or add this to the CL description: CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal Original issue's description: > A unittest that reports the statistics for the duration of an APM stream processing API call. > > BUG=webrtc:5099 > > Committed: https://crrev.com/880896ab0976bbf86a6753d0c900c70e51f421cb > Cr-Commit-Position: refs/heads/master@{#10786} TBR=henrik.lundin@webrtc.org,solenberg@webrtc.org,peah@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5099 Committed: https://crrev.com/6e004a44e8e8f3b9e9727f454ccf179911700bb3 Cr-Commit-Position: refs/heads/master@{#10791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -723 lines) Patch
D webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 1 chunk +0 lines, -720 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
kjellander_webrtc
Created Revert of Created a test that reports the statistics for the duration of APM ...
5 years ago (2015-11-25 20:27:36 UTC) #1
hlundin-webrtc
5 years ago (2015-11-27 09:01:01 UTC) #4
Message was sent while issue was closed.
RS LGTM

Powered by Google App Engine
This is Rietveld 408576698