Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1473713004:
Fix fuzzer breakage in Chromium. (Closed)
|
Created:
5 years ago by pbos-webrtc Modified:
5 years ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix fuzzer breakage in Chromium.
Removes log disabling under Chromium which doesn't compile due to
missing LS_INFO in the override log implementation.
Also removes dependency on webrtc/test/BUILD.gn which doesn't build in
Chromium (due to third_party/gflags not being present). Instead the
no-op implementation of field_trials in system_wrappers is used.
BUG=chromium:561667, webrtc:4771
R=kjellander@webrtc.org
TBR=henrikg@webrtc.org
Committed: https://crrev.com/89d658f6b4d5efabf35b50cb050f13e37cfb0cfd
Cr-Commit-Position: refs/heads/master@{#10793}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 16 (8 generated)
PTAL, this doesn't build on any trybots so a CQ is useless. (I tested this both in chromium and webrtc checkouts).
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium, which isn't yet supported. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium, which isn't yet supported. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ==========
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium, which isn't yet supported. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium, which isn't yet supported, and doesn't compile due to missing LS_INFO. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ==========
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium, which isn't yet supported, and doesn't compile due to missing LS_INFO. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ==========
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ==========
webrtc/test/fuzzers/BUILD.gn: lgtm I prefer to stay out of the logging business :) Please have someone with knowledge review that.
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org ==========
pbos@webrtc.org changed reviewers: + henrikg@webrtc.org
TBR=henrikg@ for the log disabling
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/89d658f6b4d5efabf35b50cb0... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 89d658f6b4d5efabf35b50cb050f13e37cfb0cfd (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/89d658f6b4d5efabf35b50cb0... ========== to ========== Fix fuzzer breakage in Chromium. Removes log disabling under Chromium which doesn't compile due to missing LS_INFO in the override log implementation. Also removes dependency on webrtc/test/BUILD.gn which doesn't build in Chromium (due to third_party/gflags not being present). Instead the no-op implementation of field_trials in system_wrappers is used. BUG=chromium:561667, webrtc:4771 R=kjellander@webrtc.org TBR=henrikg@webrtc.org Committed: https://crrev.com/89d658f6b4d5efabf35b50cb050f13e37cfb0cfd Cr-Commit-Position: refs/heads/master@{#10793} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/89d658f6b4d5efabf35b50cb050f13e37cfb0cfd Cr-Commit-Position: refs/heads/master@{#10793}
Message was sent while issue was closed.
https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... File webrtc/test/fuzzers/webrtc_fuzzer_main.cc (right): https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... webrtc/test/fuzzers/webrtc_fuzzer_main.cc:26: #if !defined(WEBRTC_CHROMIUM_BUILD) Do you plan to modify this function when disabling in Chromium? Otherwise, this function shouldn't be called at all when in Chromium, right?
Message was sent while issue was closed.
https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... File webrtc/test/fuzzers/webrtc_fuzzer_main.cc (right): https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... webrtc/test/fuzzers/webrtc_fuzzer_main.cc:26: #if !defined(WEBRTC_CHROMIUM_BUILD) On 2015/11/26 12:06:00, Henrik Grunell (webrtc) wrote: > Do you plan to modify this function when disabling in Chromium? Otherwise, this > function shouldn't be called at all when in Chromium, right? This exact code should work in Chromium, but currently doesn't, so when the linked bug is fixed I'll remove the ifdefs.
Message was sent while issue was closed.
lgtm https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... File webrtc/test/fuzzers/webrtc_fuzzer_main.cc (right): https://codereview.webrtc.org/1473713004/diff/1/webrtc/test/fuzzers/webrtc_fu... webrtc/test/fuzzers/webrtc_fuzzer_main.cc:26: #if !defined(WEBRTC_CHROMIUM_BUILD) On 2015/11/26 12:23:42, pbos-webrtc wrote: > On 2015/11/26 12:06:00, Henrik Grunell (webrtc) wrote: > > Do you plan to modify this function when disabling in Chromium? Otherwise, > this > > function shouldn't be called at all when in Chromium, right? > > This exact code should work in Chromium, but currently doesn't, so when the > linked bug is fixed I'll remove the ifdefs. I see. It wasn't really clear reading the todo. :) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
