Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 1473013002: Fixing direction attribute in answer for non-RTP protocols. (Closed)

Created:
5 years, 1 month ago by Taylor Brandstetter
Modified:
5 years, 1 month ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing direction attribute in answer for non-RTP protocols. "non-RTP protocols" refers to SCTP data channels. Because there are no streams for SCTP data channels, the answer was being set to RECVONLY. BUG=webrtc:5228 Committed: https://crrev.com/b5cb19b37c361a263a9cec2e2fb356d16520afd1 Cr-Commit-Position: refs/heads/master@{#10762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M talk/app/webrtc/peerconnection_unittest.cc View 2 chunks +32 lines, -2 lines 0 comments Download
M talk/session/media/mediasession.cc View 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Taylor Brandstetter
5 years, 1 month ago (2015-11-23 21:01:03 UTC) #2
pthatcher1
lgtm
5 years, 1 month ago (2015-11-23 21:28:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473013002/1
5 years, 1 month ago (2015-11-24 00:38:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 00:39:14 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:39:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5cb19b37c361a263a9cec2e2fb356d16520afd1
Cr-Commit-Position: refs/heads/master@{#10762}

Powered by Google App Engine
This is Rietveld 408576698