Resolves issue with multiple calls to audio unit initialization

Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
R=tkchin@webrtc.org

Committed: https://crrev.com/c729032b1b31e9064a37d3f862bcf60e3651bdff
Cr-Commit-Position: refs/heads/master@{#10865}

[henrika_webrtc, 2015-11-23 14:18:09]

Description was changed from

==========
Adding multi-user unit test for iOS

BUG=
==========

to

==========
Adding multi-user unit test for iOS

BUG=
==========

[henrika_webrtc, 2015-11-26 14:46:45]

Description was changed from

==========
Adding multi-user unit test for iOS

BUG=
==========

to

==========
Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
==========

[henrika_webrtc, 2015-11-26 15:18:46]

henrika@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[henrika_webrtc, 2015-11-26 15:19:07]

tkchin: PTAL

[tkchin_webrtc, 2015-11-26 15:55:03]

On 2015/11/26 15:19:13, henrika_webrtc wrote:

I think the change makes sense if we need to support multiple ADMs each with
their own vpio unit. My question is - do we need to have separate vpio units, or
can a single one be shared across ADM instances?

[henrika_webrtc, 2015-11-27 12:37:00]

Supporting multiple ADMs feels like something we need. Several different ADMs
will be created (on different threads) in a standard AppRTC call.
IMO, each instance should create its own vpio unit. The framework is designed
for just that (creating many units, connecting them etc.).
Also, each ADM should run independently and it would add one extra layer of
"reference counting" if we shared. I would rather keep this rather
small change and see how that that takes us.

[tkchin_webrtc, 2015-12-01 18:27:01]

lgtm

Let's chat offline about why there are multiple ADMs being created for a single
call though.

https://codereview.webrtc.org/1472833002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/1472833002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/audio_device_ios.mm:898: // Max number of
initialization attempts exceeded, hence abort.
nit: log abort

[henrika_webrtc, 2015-12-02 09:08:11]

https://codereview.webrtc.org/1472833002/diff/40001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/audio_device_ios.mm (right):

https://codereview.webrtc.org/1472833002/diff/40001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/audio_device_ios.mm:898: // Max number of
initialization attempts exceeded, hence abort.
On 2015/12/01 18:27:01, tkchin_webrtc wrote:
> nit: log abort

Done.

[henrika_webrtc, 2015-12-02 09:08:21]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2015-12-02 09:08:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1472833002/#ps80001 (title:
"nit")

[commit-bot: I haz the power, 2015-12-02 09:08:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472833002/80001

[henrika_webrtc, 2015-12-02 09:47:00]

Description was changed from

==========
Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
==========

to

==========
Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c729032b1b31e9064a37d3f86...
==========

[henrika_webrtc, 2015-12-02 09:47:01]

Committed patchset #5 (id:80001) manually as
c729032b1b31e9064a37d3f862bcf60e3651bdff (presubmit successful).

[commit-bot: I haz the power, 2015-12-02 09:47:02]

Description was changed from

==========
Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
R=tkchin@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/c729032b1b31e9064a37d3f86...
==========

to

==========
Resolves issue with multiple calls to audio unit initialization

BUG=webrtc:5166
R=tkchin@webrtc.org

Committed: https://crrev.com/c729032b1b31e9064a37d3f862bcf60e3651bdff
Cr-Commit-Position: refs/heads/master@{#10865}
==========

[commit-bot: I haz the power, 2015-12-02 09:47:03]

Patchset 5 (id:??) landed as
https://crrev.com/c729032b1b31e9064a37d3f862bcf60e3651bdff
Cr-Commit-Position: refs/heads/master@{#10865}