Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1471663002: GN: Fix iOS error in audio_device and rtc_base (Closed)

Created:
5 years, 1 month ago by kjellander_webrtc
Modified:
5 years ago
Reviewers:
tommi, Dirk Pranke
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, peah-webrtc, henrika_webrtc, Dirk Pranke
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix iOS error in audio_device and rtc_base With this in, the only compilation errors left seems related to yasm and libjpeg_turbo. Notice the below example builds x86 builds (not ARM) since if specifying target_cpu="arm", the gn step fails (separate issue). BUG=webrtc:5213, webrtc:5195, chromium:459705 TESTED=Passing compilation with: gn gen --args="target_os=\"ios\"" out/Default ninja -C out/Default rtc_base audio_device Committed: https://crrev.com/70bed7d4153855e508954df928ad2d9224445dc2 Cr-Commit-Position: refs/heads/master@{#10763}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +7 lines, -0 lines 1 comment Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kjellander_webrtc
This should be the right way to solve the rtc_base error that sdefresne@chromium.org tried to ...
5 years, 1 month ago (2015-11-23 09:18:36 UTC) #4
kjellander_webrtc
Notice the iOS GN bot is FYI still, as it has more issues that needs ...
5 years, 1 month ago (2015-11-23 09:19:08 UTC) #5
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-23 22:55:50 UTC) #8
tommi
lgtm
5 years, 1 month ago (2015-11-23 23:47:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471663002/1
5 years, 1 month ago (2015-11-23 23:47:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 01:23:51 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/70bed7d4153855e508954df928ad2d9224445dc2 Cr-Commit-Position: refs/heads/master@{#10763}
5 years, 1 month ago (2015-11-24 01:23:53 UTC) #13
sdefresne
5 years ago (2015-11-24 08:18:01 UTC) #14
Message was sent while issue was closed.
On 2015/11/24 at 01:23:53, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/70bed7d4153855e508954df928ad2d9224445dc2
> Cr-Commit-Position: refs/heads/master@{#10763}

Thank you.

Powered by Google App Engine
This is Rietveld 408576698