Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471203002: GetDefaultLocalAddress should return false when the address is invalid (Closed)

Created:
5 years, 1 month ago by guoweis_webrtc
Modified:
5 years ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GetDefaultLocalAddress should return false when the address is invalid BUG= R=pthatcher@webrtc.org Committed: https://crrev.com/67c6df6153b7b6dceb2b569daf683a498b2fc13c Cr-Commit-Position: refs/heads/master@{#10779} Committed: https://crrev.com/a34c39e549f384585730d0247d8b912419772b74 Cr-Commit-Position: refs/heads/master@{#10794}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M webrtc/base/network.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/network_unittest.cc View 1 3 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
pthatcher1
lgtm
5 years ago (2015-11-24 17:36:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471203002/20001
5 years ago (2015-11-24 17:37:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471203002/20001
5 years ago (2015-11-24 17:48:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years ago (2015-11-24 19:38:09 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/67c6df6153b7b6dceb2b569daf683a498b2fc13c Cr-Commit-Position: refs/heads/master@{#10779}
5 years ago (2015-11-24 19:59:35 UTC) #12
guoweis_webrtc
Committed patchset #2 (id:20001) manually as a34c39e549f384585730d0247d8b912419772b74 (presubmit successful).
5 years ago (2015-11-25 21:12:38 UTC) #14
commit-bot: I haz the power
5 years ago (2015-11-25 21:12:41 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a34c39e549f384585730d0247d8b912419772b74
Cr-Commit-Position: refs/heads/master@{#10794}

Powered by Google App Engine
This is Rietveld 408576698