Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1717)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471073005: Inline ConvertToSystemPriority. (Closed)

Created:
5 years ago by pbos-webrtc
Modified:
5 years ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Inline ConvertToSystemPriority. Unused function when building Chromium, triggered build errors when importing webrtc. BUG= R=tommi@webrtc.org Committed: https://crrev.com/97c821dc56a3cfa3674936b012c10b91fd6ea00e Cr-Commit-Position: refs/heads/master@{#10768}

Patch Set 1 #

Patch Set 2 : inline ConvertToSystemPriority #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M webrtc/base/platform_thread.cc View 1 2 chunks +22 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pbos-webrtc
ptal, this is making FYI red
5 years ago (2015-11-24 12:20:33 UTC) #1
pbos-webrtc
inline ConvertToSystemPriority
5 years ago (2015-11-24 12:28:38 UTC) #2
tommi
lgtm
5 years ago (2015-11-24 12:36:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471073005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471073005/20001
5 years ago (2015-11-24 12:36:37 UTC) #6
pbos-webrtc
Committed patchset #2 (id:20001) manually as 97c821dc56a3cfa3674936b012c10b91fd6ea00e (presubmit successful).
5 years ago (2015-11-24 12:48:27 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 12:48:29 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/97c821dc56a3cfa3674936b012c10b91fd6ea00e
Cr-Commit-Position: refs/heads/master@{#10768}

Powered by Google App Engine
This is Rietveld 408576698