Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1470973002: Android ThreadUtils: Make the class public for access outside org.webrtc (Closed)

Created:
5 years, 1 month ago by magjed_webrtc
Modified:
5 years, 1 month ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android ThreadUtils: Make the class public for access outside org.webrtc Also make the class non-final. We shouldn't use non-final classes, because then we can't mock them. R=henrika@webrtc.org Committed: https://crrev.com/1aa6efe885a130da8272542309b70116497104a7 Cr-Commit-Position: refs/heads/master@{#10757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
magjed_webrtc
henrika - Please take a look.
5 years, 1 month ago (2015-11-23 15:34:19 UTC) #3
henrika_webrtc
LGTM
5 years, 1 month ago (2015-11-23 16:06:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470973002/1
5 years, 1 month ago (2015-11-23 16:07:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-23 18:07:32 UTC) #8
magjed_webrtc
Committed patchset #1 (id:1) manually as 1aa6efe885a130da8272542309b70116497104a7 (presubmit successful).
5 years, 1 month ago (2015-11-23 19:13:41 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 19:13:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aa6efe885a130da8272542309b70116497104a7
Cr-Commit-Position: refs/heads/master@{#10757}

Powered by Google App Engine
This is Rietveld 408576698