Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1470833002: Adding a bunch of Agora IO team members to the watch lists (Closed)

Created:
5 years, 1 month ago by yujie_mao (webrtc)
Modified:
5 years ago
Reviewers:
tommi, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding a bunch of Agora IO team members to the watch lists BUG= Committed: https://crrev.com/978244ecb0900633edd25bdedc38c3da335c625e Cr-Commit-Position: refs/heads/master@{#10765}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed tommi's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -31 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M WATCHLISTS View 1 1 chunk +54 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yujie_mao (webrtc)
Hi, PTAL. We're building products using webrtc and want to monitor the changes happened in ...
5 years, 1 month ago (2015-11-23 07:05:56 UTC) #2
tommi
https://codereview.webrtc.org/1470833002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.webrtc.org/1470833002/diff/1/WATCHLISTS#newcode104 WATCHLISTS:104: 'audio-group@agora.io'], The lists should be sorted (although I see ...
5 years, 1 month ago (2015-11-23 16:50:26 UTC) #4
yujie_mao (webrtc)
On 2015/11/23 16:50:26, tommi (webrtc) wrote: > https://codereview.webrtc.org/1470833002/diff/1/WATCHLISTS > File WATCHLISTS (right): > > https://codereview.webrtc.org/1470833002/diff/1/WATCHLISTS#newcode104 ...
5 years ago (2015-11-24 03:40:16 UTC) #5
tommi
lgtm
5 years ago (2015-11-24 06:30:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470833002/20001
5 years ago (2015-11-24 06:30:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 08:22:21 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 08:22:26 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/978244ecb0900633edd25bdedc38c3da335c625e
Cr-Commit-Position: refs/heads/master@{#10765}

Powered by Google App Engine
This is Rietveld 408576698