Issue 1470363002: Revert "GetDefaultLocalAddress should return false when the address is invalid"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1470363002: Revert "GetDefaultLocalAddress should return false when the address is invalid" (Closed)

Created:
5 years ago by guoweis_webrtc

Modified:
5 years ago

Reviewers:
pthatcher1

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Revert "GetDefaultLocalAddress should return false when the address is invalid" This reverts commit 67c6df6153b7b6dceb2b569daf683a498b2fc13c. TBR=pthatcher@webrtc.org BUG= Committed: https://crrev.com/953eabc0273ba0566f2889904dd4ffb6ee50bfa9 Cr-Commit-Position: refs/heads/master@{#10780}

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -23 lines)			Patch
M	webrtc/base/network.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webrtc/base/network_unittest.cc	View	3 chunks	+1 line, -18 lines	0 comments	Download
M	webrtc/p2p/base/stunport.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

guoweis_webrtc

Committed patchset #1 (id:1) manually as 953eabc0273ba0566f2889904dd4ffb6ee50bfa9 (presubmit successful).

5 years ago (2015-11-24 20:00:41 UTC) #1

commit-bot: I haz the power

5 years ago (2015-11-24 20:00:44 UTC) #2

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/953eabc0273ba0566f2889904dd4ffb6ee50bfa9
Cr-Commit-Position: refs/heads/master@{#10780}