Support texture scaling in Androids MediaEncoder

Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image before encoding. The purpose is to allow downscaling if the quality is too bad at the current resolution.
BUG=webrtc:4993
R=magjed@webrtc.org, pbos@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/598242a583564c5816a4b3b3c93f5cccf2395a17

[perkj_webrtc, 2015-11-24 21:30:20]

perkj@webrtc.org changed reviewers:
+ magjed@webrtc.org

[perkj_webrtc, 2015-11-24 21:30:21]

Please take a look. Something like this then...

[perkj_webrtc, 2015-11-25 10:16:54]

perkj@webrtc.org changed reviewers:
+ pbos@webrtc.org

[perkj_webrtc, 2015-11-25 10:16:55]

Hej, peter, can you help with an opinion about how I use the quality scaler in
androidmediencoder when scaling a texture? 
We need an android specicific way of doing the scaling. So the question is how.
I can either do as in this cl or I can change the QualityScaler take a Scaler as
input where I override the scaling method for Android.

[pbos-webrtc, 2015-11-26 09:41:37]

lgtm for mediaencoder and quality_scaler

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:580: if
(quality_scaler_.GetScaledResolution().width != frame.width() ||
Get scaled resolution once, this looks clunky. Otherwise I think it's good.

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:583:
rtc::scoped_refptr<webrtc::VideoFrameBuffer> scaled_buffer(
If you wanna put a comment on how the crop-and-scale thing works (no actual
copy), feel free to do so.

[perkj_webrtc, 2015-11-26 12:58:49]

magjed - please?

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
File talk/app/webrtc/java/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:580: if
(quality_scaler_.GetScaledResolution().width != frame.width() ||
On 2015/11/26 09:41:37, pbos-webrtc wrote:
> Get scaled resolution once, this looks clunky. Otherwise I think it's good.

Done.

https://codereview.webrtc.org/1470043002/diff/60001/talk/app/webrtc/java/jni/...
talk/app/webrtc/java/jni/androidmediaencoder_jni.cc:583:
rtc::scoped_refptr<webrtc::VideoFrameBuffer> scaled_buffer(
On 2015/11/26 09:41:37, pbos-webrtc wrote:
> If you wanna put a comment on how the crop-and-scale thing works (no actual
> copy), feel free to do so.

No I don't :-> Read the code...

[perkj_webrtc, 2015-11-26 13:22:29]

Description was changed from

==========
Support texture scaling. WIP.

BUG=
==========

to

==========
Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image
before encoding. The purpose is to allow downscaling if the quality is too bad
at the current resolution.
BUG=webrtc:4993
==========

[magjed_webrtc, 2015-11-26 13:23:34]

https://codereview.webrtc.org/1470043002/diff/100001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/utility/quality_scaler.h (right):

https://codereview.webrtc.org/1470043002/diff/100001/webrtc/modules/video_cod...
webrtc/modules/video_coding/utility/quality_scaler.h:37: const Resolution&
GetScaledResolution() const;
I don't like this change. I prefer to return non-ref. Any performance difference
should be negligible. If you want to make a change, I think you should make
GetScaledFrame() return a non-ref as well and remove |scaled_frame_|. The
VideoFrame can be a local variable in GetScaledFrame() instead.

[magjed_webrtc, 2015-11-26 13:28:26]

patch 7, lgtm.

[perkj_webrtc, 2015-11-26 13:29:08]

Description was changed from

==========
Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image
before encoding. The purpose is to allow downscaling if the quality is too bad
at the current resolution.
BUG=webrtc:4993
==========

to

==========
Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image
before encoding. The purpose is to allow downscaling if the quality is too bad
at the current resolution.
BUG=webrtc:4993
R=magjed@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/598242a583564c5816a4b3b3c...
==========

[commit-bot: I haz the power, 2015-11-26 13:29:09]

Description was changed from

==========
Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image
before encoding. The purpose is to allow downscaling if the quality is too bad
at the current resolution.
BUG=webrtc:4993
R=magjed@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/598242a583564c5816a4b3b3c...
==========

to

==========
Support texture scaling in Androids MediaEncoder.
This cl make it possible for the hw video encoder to downscale a texture image
before encoding. The purpose is to allow downscaling if the quality is too bad
at the current resolution.
BUG=webrtc:4993
R=magjed@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/598242a583564c5816a4b3b3c93f5cccf2395a17
Cr-Commit-Position: refs/heads/master@{#10804}
==========

[perkj_webrtc, 2015-11-26 13:29:10]

Committed patchset #7 (id:120001) manually as
598242a583564c5816a4b3b3c93f5cccf2395a17 (presubmit successful).

[commit-bot: I haz the power, 2015-11-26 13:29:10]

Patchset 7 (id:??) landed as
https://crrev.com/598242a583564c5816a4b3b3c93f5cccf2395a17
Cr-Commit-Position: refs/heads/master@{#10804}