Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: webrtc/base/platform_thread_types.h

Issue 1469013002: Move ThreadWrapper to ProcessThread in base. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: we don't need no stinkin std::move Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/platform_thread_types.h
diff --git a/webrtc/base/platform_thread.h b/webrtc/base/platform_thread_types.h
similarity index 66%
copy from webrtc/base/platform_thread.h
copy to webrtc/base/platform_thread_types.h
index 50033b39282e976cd3f3f4ec35cb52b641249843..dda2c3e6268ec27d6185e8b05eb5b1b23081c65e 100644
--- a/webrtc/base/platform_thread.h
+++ b/webrtc/base/platform_thread_types.h
@@ -8,8 +8,11 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#ifndef WEBRTC_BASE_PLATFORM_THREAD_H_
-#define WEBRTC_BASE_PLATFORM_THREAD_H_
+#ifndef WEBRTC_BASE_PLATFORM_THREAD_TYPES_H_
+#define WEBRTC_BASE_PLATFORM_THREAD_TYPES_H_
+// This file exists so that PlatformThread can make use of ThreadChecker which
tommi 2015/11/23 15:54:28 nit: I think you can skip this comment. It just r
pbos-webrtc 2015/11/23 16:18:23 Done.
+// requires these types, so to avoid PlatformThread -> ThreadChecker ->
+// PlatformThread dependencies they can both depend on this file.
#if defined(WEBRTC_WIN)
#include <winsock2.h>
@@ -20,7 +23,6 @@
#endif
namespace rtc {
-
#if defined(WEBRTC_WIN)
typedef DWORD PlatformThreadId;
typedef DWORD PlatformThreadRef;
@@ -28,16 +30,6 @@ typedef DWORD PlatformThreadRef;
typedef pid_t PlatformThreadId;
typedef pthread_t PlatformThreadRef;
#endif
-
-PlatformThreadId CurrentThreadId();
-PlatformThreadRef CurrentThreadRef();
-
-// Compares two thread identifiers for equality.
-bool IsThreadRefEqual(const PlatformThreadRef& a, const PlatformThreadRef& b);
-
-// Sets the current thread name.
-void SetCurrentThreadName(const char* name);
-
} // namespace rtc
-#endif // WEBRTC_BASE_PLATFORM_THREAD_H_
+#endif // WEBRTC_BASE_PLATFORM_THREAD_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698